Adding DRP specfic UMA for FirstContentfulPaint

content/public/browser/navigation_data.h

+// Copyright 2016 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef CONTENT_PUBLIC_BROWSER_NAVIGATION_DATA_H_
+#define CONTENT_PUBLIC_BROWSER_NAVIGATION_DATA_H_
+
+#include <memory>
+
+#include "base/macros.h"

[bengr, 2016/04/29 21:14:23]

Why is this here? Did you mean to add DISALLOW_COPY_AND_ASSIGN?

[RyanSturm, 2016/05/02 19:52:22]

Removing, each inheritor should deal with disallowing copy/assign.

+
+namespace content {
+
+// Copyable interface for embedders to pass opaque data to content. It is
+// expected to be created on the IO thread, and content will transfer it to the
+// UI thread as a Clone.

[bengr, 2016/04/29 21:14:23]

Clone -> clone

[RyanSturm, 2016/05/02 19:52:22]

Done.

+class NavigationData {
+ public:
+  virtual ~NavigationData(){};
+
+  // Creates a new NavigationData that is  a deep copy of the original, and

[bengr, 2016/04/29 21:14:23]

is  a -> is a

"and could be used cross-thread" seems unnecessary.

[RyanSturm, 2016/05/02 19:52:22]

Done.

+  // could be used cross-thread.
+  virtual std::unique_ptr<NavigationData> Clone() const = 0;
+};
+
+}  // namespace content
+
+#endif  // CONTENT_PUBLIC_BROWSER_NAVIGATION_DATA_H_