Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1789)

Unified Diff: chrome/browser/page_load_metrics/observers/page_load_metrics_observer_test_harness.h

Issue 1721813002: Adding DRP specfic UMA for FirstContentfulPaint (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Missing Header Include Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/page_load_metrics/observers/page_load_metrics_observer_test_harness.h
diff --git a/chrome/browser/page_load_metrics/observers/page_load_metrics_observer_test_harness.h b/chrome/browser/page_load_metrics/observers/page_load_metrics_observer_test_harness.h
index dfd69a9e22c278017ba07718777ad4a8da3968b2..5b809dafc176cb101813750f798600dfae569d26 100644
--- a/chrome/browser/page_load_metrics/observers/page_load_metrics_observer_test_harness.h
+++ b/chrome/browser/page_load_metrics/observers/page_load_metrics_observer_test_harness.h
@@ -4,20 +4,25 @@
#ifndef CHROME_BROWSER_PAGE_LOAD_METRICS_OBSERVERS_PAGE_LOAD_METRICS_OBSERVER_TEST_HARNESS_H_
#define CHROME_BROWSER_PAGE_LOAD_METRICS_OBSERVERS_PAGE_LOAD_METRICS_OBSERVER_TEST_HARNESS_H_
#include "base/macros.h"
#include "base/test/histogram_tester.h"
#include "chrome/test/base/chrome_render_view_host_test_harness.h"
#include "components/page_load_metrics/browser/metrics_web_contents_observer.h"
#include "content/public/test/web_contents_tester.h"
+namespace content {
+class NavigationData;
+class NavigationHandle;
+}
+
namespace page_load_metrics {
// This class can be used to drive tests of PageLoadMetricsObservers. To hook up
// an observer, override RegisterObservers and call tracker->AddObserver. This
// will attach the observer to all main frame navigations.
class PageLoadMetricsObserverTestHarness
: public ChromeRenderViewHostTestHarness {
public:
PageLoadMetricsObserverTestHarness();
~PageLoadMetricsObserverTestHarness() override;
@@ -34,20 +39,25 @@ class PageLoadMetricsObserverTestHarness
// navigation.
void StartNavigation(const GURL& gurl);
// Call this to simulate sending a PageLoadTiming IPC from the render process
// to the browser process. These will update the timing information for the
// most recently committed navigation.
void SimulateTimingUpdate(const PageLoadTiming& timing);
void SimulateTimingAndMetadataUpdate(const PageLoadTiming& timing,
const PageLoadMetadata& metadata);
+ // Sets NavigationData on |navigation_handle|
+ void SetNavigationData(
+ content::NavigationHandle* navigation_handle,
+ std::unique_ptr<content::NavigationData> navigation_data);
+
const base::HistogramTester& histogram_tester() const;
private:
base::HistogramTester histogram_tester_;
MetricsWebContentsObserver* observer_;
DISALLOW_COPY_AND_ASSIGN(PageLoadMetricsObserverTestHarness);
};
} // namespace page_load_metrics

Powered by Google App Engine
This is Rietveld 408576698