Adding DRP specfic UMA for FirstContentfulPaint

chrome/browser/page_load_metrics/observers/data_reduction_proxy_metrics_observer_unittest.cc

Index: chrome/browser/page_load_metrics/observers/data_reduction_proxy_metrics_observer_unittest.cc
diff --git a/chrome/browser/page_load_metrics/observers/data_reduction_proxy_metrics_observer_unittest.cc b/chrome/browser/page_load_metrics/observers/data_reduction_proxy_metrics_observer_unittest.cc
new file mode 100644
index 0000000000000000000000000000000000000000..6b072c916bd23f77e9fdfaae02dca5c0a819b648
--- /dev/null
+++ b/chrome/browser/page_load_metrics/observers/data_reduction_proxy_metrics_observer_unittest.cc
@@ -0,0 +1,211 @@
+// Copyright 2016 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "chrome/browser/page_load_metrics/observers/data_reduction_proxy_metrics_observer.h"
+
+#include <memory>
+
+#include "base/memory/ptr_util.h"
+#include "base/metrics/field_trial.h"
+#include "base/time/time.h"
+#include "chrome/browser/page_load_metrics/observers/page_load_metrics_observer_test_harness.h"
+#include "chrome/browser/renderer_host/chrome_navigation_data.h"
+#include "chrome/test/base/testing_browser_process.h"
+#include "components/data_reduction_proxy/core/browser/data_reduction_proxy_data.h"
+#include "components/data_reduction_proxy/core/common/data_reduction_proxy_params.h"
+#include "components/page_load_metrics/common/page_load_timing.h"
+
+namespace {
+
+const char kDefaultTestUrl[] = "https://google.com";
+const char kDefaultTestUrl2[] = "https://example.com";
+
+}  // namespace
+
+class DataReductionProxyMetricsObserverWrapper
+    : public page_load_metrics::PageLoadMetricsObserver {
+ public:
+  DataReductionProxyMetricsObserverWrapper(
+      data_reduction_proxy::DataReductionProxyMetricsObserver* observer,
+      page_load_metrics::PageLoadMetricsObserverTestHarness* test,
+      bool data_reduction_proxy_used,
+      bool is_using_lofi)
+      : observer_(observer),
+        test_(test),
+        data_reduction_proxy_used_(data_reduction_proxy_used),
+        is_using_lofi_(is_using_lofi) {}
+
+  ~DataReductionProxyMetricsObserverWrapper() override {}
+
+  // page_load_metrics::PageLoadMetricsObserver implementation:
+  void OnCommit(content::NavigationHandle* navigation_handle) override {
+    data_reduction_proxy::DataReductionProxyData* data =
+        DataForNavigationHandle(navigation_handle);
+    data->set_used_data_reduction_proxy(data_reduction_proxy_used_);
+    data->set_is_using_lofi(is_using_lofi_);
+    observer_->OnCommit(navigation_handle);
+  }
+
+  void OnComplete(const page_load_metrics::PageLoadTiming& timing,
+                  const page_load_metrics::PageLoadExtraInfo& info) override {
+    observer_->OnComplete(timing, info);
+  }
+
+  data_reduction_proxy::DataReductionProxyData* DataForNavigationHandle(
+      content::NavigationHandle* navigation_handle) {
+    ChromeNavigationData* chrome_navigation_data =
+        static_cast<ChromeNavigationData*>(
+            navigation_handle->GetNavigationData());
+    if (!chrome_navigation_data) {
+      chrome_navigation_data = new ChromeNavigationData();
+      content::WebContentsTester::For(test_->web_contents())
+          ->SetNavigationData(navigation_handle,
+                              base::WrapUnique(chrome_navigation_data));
+    }
+
+    data_reduction_proxy::DataReductionProxyData* data =
+        chrome_navigation_data->GetDataReductionProxyData();
+    if (!data) {
+      data = new data_reduction_proxy::DataReductionProxyData();
+      chrome_navigation_data->SetDataReductionProxyData(base::WrapUnique(data));
+    }
+    return data;
+  }
+
+ private:
+  std::unique_ptr<data_reduction_proxy::DataReductionProxyMetricsObserver>
+      observer_;
+  page_load_metrics::PageLoadMetricsObserverTestHarness* test_;
+  bool data_reduction_proxy_used_;
+  bool is_using_lofi_;

[bengr, 2016/04/29 21:14:20]

lofi_used_?

[RyanSturm, 2016/05/02 19:52:19]

Done.

+};
+
+class DataReductionProxyMetricsObserverTest
+    : public page_load_metrics::PageLoadMetricsObserverTestHarness {
+ public:
+  DataReductionProxyMetricsObserverTest()
+      : data_reduction_proxy_used_(false), is_using_lofi_(false) {}
+
+ protected:
+  void RegisterObservers(page_load_metrics::PageLoadTracker* tracker) override {
+    tracker->AddObserver(
+        base::WrapUnique(new DataReductionProxyMetricsObserverWrapper(
+            new data_reduction_proxy::DataReductionProxyMetricsObserver(), this,
+            data_reduction_proxy_used_, is_using_lofi_)));
+  }
+
+  bool data_reduction_proxy_used_;
+  bool is_using_lofi_;
+};
+
+TEST_F(DataReductionProxyMetricsObserverTest, DataReductionProxyOff) {
+  page_load_metrics::PageLoadTiming timing;
+  timing.navigation_start = base::Time::FromDoubleT(1);
+  timing.first_contentful_paint = base::TimeDelta::FromSeconds(1);
+  PopulateRequiredTimingFields(&timing);
+
+  NavigateAndCommit(GURL(kDefaultTestUrl));
+  SimulateTimingUpdate(timing);
+
+  // Navigate again to force logging.

[bengr, 2016/04/29 21:14:20]

Add an explanation of why a second navigation forces logging. Also, you mean UMA
reporting, not logging, right?

[RyanSturm, 2016/05/02 19:52:19]

Done.

+  NavigateAndCommit(GURL(kDefaultTestUrl2));
+  histogram_tester().ExpectTotalCount(
+      data_reduction_proxy::internal::
+          kHistogramFirstContentfulPaintDataReductionProxy,
+      0);
+  histogram_tester().ExpectTotalCount(
+      data_reduction_proxy::internal::
+          kHistogramFirstContentfulPaintDataReductionProxyAutoLofiOn,
+      0);
+  histogram_tester().ExpectTotalCount(
+      data_reduction_proxy::internal::
+          kHistogramFirstContentfulPaintDataReductionProxyAutoLofiOff,
+      0);
+}
+
+TEST_F(DataReductionProxyMetricsObserverTest, DataReductionProxyOn) {
+  page_load_metrics::PageLoadTiming timing;
+  timing.navigation_start = base::Time::FromDoubleT(1);
+  timing.first_contentful_paint = base::TimeDelta::FromSeconds(1);
+  PopulateRequiredTimingFields(&timing);
+
+  data_reduction_proxy_used_ = true;
+  NavigateAndCommit(GURL(kDefaultTestUrl));
+  SimulateTimingUpdate(timing);
+
+  // Navigate again to force logging.
+  NavigateAndCommit(GURL(kDefaultTestUrl2));
+  histogram_tester().ExpectTotalCount(
+      data_reduction_proxy::internal::
+          kHistogramFirstContentfulPaintDataReductionProxy,
+      1);
+  histogram_tester().ExpectTotalCount(
+      data_reduction_proxy::internal::
+          kHistogramFirstContentfulPaintDataReductionProxyAutoLofiOn,
+      0);
+  histogram_tester().ExpectTotalCount(
+      data_reduction_proxy::internal::
+          kHistogramFirstContentfulPaintDataReductionProxyAutoLofiOff,
+      0);
+}
+
+TEST_F(DataReductionProxyMetricsObserverTest, LofiEnabledFieldTrial) {
+  page_load_metrics::PageLoadTiming timing;
+  timing.navigation_start = base::Time::FromDoubleT(1);
+  timing.first_contentful_paint = base::TimeDelta::FromSeconds(1);
+  PopulateRequiredTimingFields(&timing);
+
+  data_reduction_proxy_used_ = true;
+  is_using_lofi_ = true;
+  base::FieldTrialList field_trial_list(nullptr);
+  base::FieldTrialList::CreateFieldTrial(
+      data_reduction_proxy::params::GetLoFiFieldTrialName(), "Enabled");
+  NavigateAndCommit(GURL(kDefaultTestUrl));
+  SimulateTimingUpdate(timing);
+
+  // Navigate again to force logging.
+  NavigateAndCommit(GURL(kDefaultTestUrl2));
+  histogram_tester().ExpectTotalCount(
+      data_reduction_proxy::internal::
+          kHistogramFirstContentfulPaintDataReductionProxy,
+      1);
+  histogram_tester().ExpectTotalCount(
+      data_reduction_proxy::internal::
+          kHistogramFirstContentfulPaintDataReductionProxyAutoLofiOn,
+      1);
+  histogram_tester().ExpectTotalCount(
+      data_reduction_proxy::internal::
+          kHistogramFirstContentfulPaintDataReductionProxyAutoLofiOff,
+      0);
+}
+
+TEST_F(DataReductionProxyMetricsObserverTest, LofiControlFieldTrial) {
+  page_load_metrics::PageLoadTiming timing;
+  timing.navigation_start = base::Time::FromDoubleT(1);
+  timing.first_contentful_paint = base::TimeDelta::FromSeconds(1);
+  PopulateRequiredTimingFields(&timing);
+
+  data_reduction_proxy_used_ = true;
+  is_using_lofi_ = true;
+  base::FieldTrialList field_trial_list(nullptr);
+  base::FieldTrialList::CreateFieldTrial(
+      data_reduction_proxy::params::GetLoFiFieldTrialName(), "Control");
+  NavigateAndCommit(GURL(kDefaultTestUrl));
+  SimulateTimingUpdate(timing);
+
+  // Navigate again to force logging.
+  NavigateAndCommit(GURL(kDefaultTestUrl2));
+  histogram_tester().ExpectTotalCount(
+      data_reduction_proxy::internal::
+          kHistogramFirstContentfulPaintDataReductionProxy,
+      1);
+  histogram_tester().ExpectTotalCount(
+      data_reduction_proxy::internal::
+          kHistogramFirstContentfulPaintDataReductionProxyAutoLofiOn,
+      0);
+  histogram_tester().ExpectTotalCount(
+      data_reduction_proxy::internal::
+          kHistogramFirstContentfulPaintDataReductionProxyAutoLofiOff,
+      1);
+}