Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1502)

Unified Diff: content/public/browser/navigation_handle.h

Issue 1721813002: Adding DRP specfic UMA for FirstContentfulPaint (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: NavigationData final draft before adding tests Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/public/browser/navigation_handle.h
diff --git a/content/public/browser/navigation_handle.h b/content/public/browser/navigation_handle.h
index 124ef31b0ab042f9db51b1a4a4257c009f8a9dff..302b60a39012e70d0f33191869805dc549649b6a 100644
--- a/content/public/browser/navigation_handle.h
+++ b/content/public/browser/navigation_handle.h
@@ -1,20 +1,22 @@
// Copyright 2015 The Chromium Authors. All rights reserved.
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
#ifndef CONTENT_PUBLIC_BROWSER_NAVIGATION_HANDLE_H_
#define CONTENT_PUBLIC_BROWSER_NAVIGATION_HANDLE_H_
#include <memory>
+#include "base/supports_user_data.h"
nasko 2016/04/26 20:18:40 No need anymore for supports_user_data.h
RyanSturm 2016/04/27 23:27:47 Done.
#include "content/common/content_export.h"
+#include "content/public/browser/navigation_data.h"
#include "content/public/browser/navigation_throttle.h"
#include "content/public/common/referrer.h"
#include "net/base/net_errors.h"
#include "ui/base/page_transition_types.h"
class GURL;
namespace content {
class NavigationThrottle;
class RenderFrameHost;
@@ -161,15 +163,20 @@ class CONTENT_EXPORT NavigationHandle {
bool has_user_gesture,
ui::PageTransition transition,
bool is_external_protocol) = 0;
// Simulates the network request being redirected.
virtual NavigationThrottle::ThrottleCheckResult
CallWillRedirectRequestForTesting(const GURL& new_url,
bool new_method_is_post,
const GURL& new_referrer_url,
bool new_is_external_protocol) = 0;
+
+ // The NavigationData that the embedder returned from
+ // ResourceDispatcherHostDelegate::GetNavigationData during commit. This may
nasko 2016/04/26 20:18:40 "may be a clone" - isn't it definitely a clone/cop
RyanSturm 2016/04/27 23:27:47 Done.
+ // be a clone of the NavigationData.
+ virtual NavigationData* GetNavigationData() const = 0;
nasko 2016/04/26 20:18:40 No const usage in the content/ public API - https:
RyanSturm 2016/04/27 23:27:47 Done.
};
} // namespace content
#endif // CONTENT_PUBLIC_BROWSER_NAVIGATION_HANDLE_H_

Powered by Google App Engine
This is Rietveld 408576698