Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(483)

Side by Side Diff: content/public/browser/navigation_handle.h

Issue 1721813002: Adding DRP specfic UMA for FirstContentfulPaint (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: NavigationData final draft before adding tests Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CONTENT_PUBLIC_BROWSER_NAVIGATION_HANDLE_H_ 5 #ifndef CONTENT_PUBLIC_BROWSER_NAVIGATION_HANDLE_H_
6 #define CONTENT_PUBLIC_BROWSER_NAVIGATION_HANDLE_H_ 6 #define CONTENT_PUBLIC_BROWSER_NAVIGATION_HANDLE_H_
7 7
8 #include <memory> 8 #include <memory>
9 9
10 #include "base/supports_user_data.h"
nasko 2016/04/26 20:18:40 No need anymore for supports_user_data.h
RyanSturm 2016/04/27 23:27:47 Done.
10 #include "content/common/content_export.h" 11 #include "content/common/content_export.h"
12 #include "content/public/browser/navigation_data.h"
11 #include "content/public/browser/navigation_throttle.h" 13 #include "content/public/browser/navigation_throttle.h"
12 #include "content/public/common/referrer.h" 14 #include "content/public/common/referrer.h"
13 #include "net/base/net_errors.h" 15 #include "net/base/net_errors.h"
14 #include "ui/base/page_transition_types.h" 16 #include "ui/base/page_transition_types.h"
15 17
16 class GURL; 18 class GURL;
17 19
18 namespace content { 20 namespace content {
19 class NavigationThrottle; 21 class NavigationThrottle;
20 class RenderFrameHost; 22 class RenderFrameHost;
(...skipping 140 matching lines...) Expand 10 before | Expand all | Expand 10 after
161 bool has_user_gesture, 163 bool has_user_gesture,
162 ui::PageTransition transition, 164 ui::PageTransition transition,
163 bool is_external_protocol) = 0; 165 bool is_external_protocol) = 0;
164 166
165 // Simulates the network request being redirected. 167 // Simulates the network request being redirected.
166 virtual NavigationThrottle::ThrottleCheckResult 168 virtual NavigationThrottle::ThrottleCheckResult
167 CallWillRedirectRequestForTesting(const GURL& new_url, 169 CallWillRedirectRequestForTesting(const GURL& new_url,
168 bool new_method_is_post, 170 bool new_method_is_post,
169 const GURL& new_referrer_url, 171 const GURL& new_referrer_url,
170 bool new_is_external_protocol) = 0; 172 bool new_is_external_protocol) = 0;
173
174 // The NavigationData that the embedder returned from
175 // ResourceDispatcherHostDelegate::GetNavigationData during commit. This may
nasko 2016/04/26 20:18:40 "may be a clone" - isn't it definitely a clone/cop
RyanSturm 2016/04/27 23:27:47 Done.
176 // be a clone of the NavigationData.
177 virtual NavigationData* GetNavigationData() const = 0;
nasko 2016/04/26 20:18:40 No const usage in the content/ public API - https:
RyanSturm 2016/04/27 23:27:47 Done.
171 }; 178 };
172 179
173 } // namespace content 180 } // namespace content
174 181
175 #endif // CONTENT_PUBLIC_BROWSER_NAVIGATION_HANDLE_H_ 182 #endif // CONTENT_PUBLIC_BROWSER_NAVIGATION_HANDLE_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698