Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(811)

Unified Diff: content/public/browser/navigation_handle.h

Issue 1721813002: Adding DRP specfic UMA for FirstContentfulPaint (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/public/browser/navigation_handle.h
diff --git a/content/public/browser/navigation_handle.h b/content/public/browser/navigation_handle.h
index f8a3b5e02fda3d45e37658e55253a77c4d3740bf..35161f52272fe9e987cdb313fc92dcdd82b665ef 100644
--- a/content/public/browser/navigation_handle.h
+++ b/content/public/browser/navigation_handle.h
@@ -159,15 +159,21 @@ class CONTENT_EXPORT NavigationHandle {
bool has_user_gesture,
ui::PageTransition transition,
bool is_external_protocol) = 0;
// Simulates the network request being redirected.
virtual NavigationThrottle::ThrottleCheckResult
CallWillRedirectRequestForTesting(const GURL& new_url,
bool new_method_is_post,
const GURL& new_referrer_url,
bool new_is_external_protocol) = 0;
+
+ // Whether the navigation requested a LoFi version of the resource or not
bengr 2016/02/26 22:53:58 All comments should be complete sentences. At the
RyanSturm 2016/03/01 19:36:04 Done.
+ virtual bool IsUsingLofi() = 0;
bengr 2016/02/26 22:53:57 This should probably be a const method.
RyanSturm 2016/03/01 19:36:04 Done.
+
+ // Whether this navigation fetched it's resource through DataReductionProxy
bengr 2016/02/26 22:53:58 Wrong "its."
+ virtual bool WasFetchedViaDataReductionProxy() = 0;
bengr 2016/02/26 22:53:58 Also const.
RyanSturm 2016/03/01 19:36:04 Done.
};
} // namespace content
#endif // CONTENT_PUBLIC_BROWSER_NAVIGATION_HANDLE_H_

Powered by Google App Engine
This is Rietveld 408576698