content/public/browser/navigation_handle.h - Issue 1721813002: Adding DRP specfic UMA for FirstContentfulPaint

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: content/public/browser/navigation_handle.h

Issue 1721813002: Adding DRP specfic UMA for FirstContentfulPaint (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« content/common/frame_messages.h ('K') | « content/common/resource_messages.h ('k') | content/public/browser/resource_dispatcher_host_delegate.h » ('j') | content/public/common/resource_response_info.h » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 // Copyright 2015 The Chromium Authors. All rights reserved.	1 // Copyright 2015 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #ifndef CONTENT_PUBLIC_BROWSER_NAVIGATION_HANDLE_H_	5 #ifndef CONTENT_PUBLIC_BROWSER_NAVIGATION_HANDLE_H_

6 #define CONTENT_PUBLIC_BROWSER_NAVIGATION_HANDLE_H_	6 #define CONTENT_PUBLIC_BROWSER_NAVIGATION_HANDLE_H_

7	7

8 #include "content/common/content_export.h"	8 #include "content/common/content_export.h"

9 #include "content/public/browser/navigation_throttle.h"	9 #include "content/public/browser/navigation_throttle.h"

10 #include "content/public/common/referrer.h"	10 #include "content/public/common/referrer.h"

(...skipping 148 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
159 bool has_user_gesture,	159 bool has_user_gesture,

160 ui::PageTransition transition,	160 ui::PageTransition transition,

161 bool is_external_protocol) = 0;	161 bool is_external_protocol) = 0;

162	162

163 // Simulates the network request being redirected.	163 // Simulates the network request being redirected.

164 virtual NavigationThrottle::ThrottleCheckResult	164 virtual NavigationThrottle::ThrottleCheckResult

165 CallWillRedirectRequestForTesting(const GURL& new_url,	165 CallWillRedirectRequestForTesting(const GURL& new_url,

166 bool new_method_is_post,	166 bool new_method_is_post,

167 const GURL& new_referrer_url,	167 const GURL& new_referrer_url,

168 bool new_is_external_protocol) = 0;	168 bool new_is_external_protocol) = 0;

	169

	170 // Whether the navigation requested a LoFi version of the resource or not
	bengr 2016/02/26 22:53:58 All comments should be complete sentences. At the All comments should be complete sentences. At the very least, end with a period. RyanSturm 2016/03/01 19:36:04 Done. Show quoted text On 2016/02/26 22:53:58, bengr wrote: > All comments should be complete sentences. At the very least, end with a period. Done.
	171 virtual bool IsUsingLofi() = 0;
	bengr 2016/02/26 22:53:57 This should probably be a const method. This should probably be a const method. RyanSturm 2016/03/01 19:36:04 Done. Show quoted text On 2016/02/26 22:53:57, bengr wrote: > This should probably be a const method. Done.
	172

	173 // Whether this navigation fetched it's resource through DataReductionProxy
	bengr 2016/02/26 22:53:58 Wrong "its." Wrong "its."
	174 virtual bool WasFetchedViaDataReductionProxy() = 0;
	bengr 2016/02/26 22:53:58 Also const. Also const. RyanSturm 2016/03/01 19:36:04 Done. Show quoted text On 2016/02/26 22:53:58, bengr wrote: > Also const. Done.
169 };	175 };

170	176

171 } // namespace content	177 } // namespace content

172	178

173 #endif // CONTENT_PUBLIC_BROWSER_NAVIGATION_HANDLE_H_	179 #endif // CONTENT_PUBLIC_BROWSER_NAVIGATION_HANDLE_H_

OLD	NEW