Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(42)

Issue 1721723002: [interpreter] Clean super property handling. (Closed)

Created:
4 years, 10 months ago by oth
Modified:
4 years, 10 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[interpreter] Clean super property handling. SuperPropertyArgumnets is less useful after deprecating strong mode. BUG=v8:4280, v8:4682 LOG=N Committed: https://crrev.com/bd9df50d75125ee2ad37b3d92c8f50f0a8b5f030 Cr-Commit-Position: refs/heads/master@{#34215}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Address review comments in patch set 1. #

Patch Set 3 : Rebase. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+153 lines, -148 lines) Patch
M src/interpreter/bytecode-generator.h View 1 3 chunks +9 lines, -13 lines 0 comments Download
M src/interpreter/bytecode-generator.cc View 1 13 chunks +144 lines, -122 lines 0 comments Download
M src/interpreter/bytecode-register-allocator.h View 1 chunk +0 lines, -5 lines 0 comments Download
M src/interpreter/bytecode-register-allocator.cc View 1 chunk +0 lines, -8 lines 0 comments Download

Messages

Total messages: 12 (4 generated)
oth
Ross, PTAL, a fairly mechanical change. Michi, if you had a different approach in mind ...
4 years, 10 months ago (2016-02-22 15:00:48 UTC) #2
rmcilroy
Thanks for doing this. LGTM with a suggestion. https://codereview.chromium.org/1721723002/diff/1/src/interpreter/bytecode-generator.cc File src/interpreter/bytecode-generator.cc (right): https://codereview.chromium.org/1721723002/diff/1/src/interpreter/bytecode-generator.cc#newcode1065 src/interpreter/bytecode-generator.cc:1065: BuildNamedSuperPropertyStore(receiver); ...
4 years, 10 months ago (2016-02-22 20:45:10 UTC) #3
oth
On 2016/02/22 20:45:10, rmcilroy wrote: > Thanks for doing this. LGTM with a suggestion. > ...
4 years, 10 months ago (2016-02-23 10:48:23 UTC) #4
rmcilroy
Great, LGTM thanks!
4 years, 10 months ago (2016-02-23 11:04:52 UTC) #5
Michael Starzinger
LGTM. Thanks!
4 years, 10 months ago (2016-02-23 11:46:29 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1721723002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1721723002/40001
4 years, 10 months ago (2016-02-23 15:21:09 UTC) #9
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 10 months ago (2016-02-23 15:41:02 UTC) #10
commit-bot: I haz the power
4 years, 10 months ago (2016-02-23 15:42:13 UTC) #12
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/bd9df50d75125ee2ad37b3d92c8f50f0a8b5f030
Cr-Commit-Position: refs/heads/master@{#34215}

Powered by Google App Engine
This is Rietveld 408576698