[interpreter] Clean super property handling.

[interpreter] Clean super property handling.

SuperPropertyArgumnets is less useful after deprecating strong mode.

BUG=v8:4280, v8:4682
LOG=N

Committed: https://crrev.com/bd9df50d75125ee2ad37b3d92c8f50f0a8b5f030
Cr-Commit-Position: refs/heads/master@{#34215}

[oth, 2016-02-22 15:00:48]

oth@chromium.org changed reviewers:
+ mstarzinger@chromium.org, rmcilroy@chromium.org

[oth, 2016-02-22 15:00:48]

Ross, PTAL, a fairly mechanical change.

Michi, if you had a different approach in mind let me know.

Thanks

[rmcilroy, 2016-02-22 20:45:10]

Thanks for doing this. LGTM with a suggestion.

https://codereview.chromium.org/1721723002/diff/1/src/interpreter/bytecode-ge...
File src/interpreter/bytecode-generator.cc (right):

https://codereview.chromium.org/1721723002/diff/1/src/interpreter/bytecode-ge...
src/interpreter/bytecode-generator.cc:1065:
BuildNamedSuperPropertyStore(receiver);
Could you pass the other registers as arguments too and just do a
DCHECK(AreContigious(...)) on them to ensure the assumptions made by the
function hold.

https://codereview.chromium.org/1721723002/diff/1/src/interpreter/bytecode-ge...
src/interpreter/bytecode-generator.cc:1081:
BuildKeyedSuperPropertyStore(receiver);
Ditto (and for the others).

[oth, 2016-02-23 10:48:23]

On 2016/02/22 20:45:10, rmcilroy wrote:
> Thanks for doing this. LGTM with a suggestion.
> 
>
https://codereview.chromium.org/1721723002/diff/1/src/interpreter/bytecode-ge...
> File src/interpreter/bytecode-generator.cc (right):
> 
>
https://codereview.chromium.org/1721723002/diff/1/src/interpreter/bytecode-ge...
> src/interpreter/bytecode-generator.cc:1065:
> BuildNamedSuperPropertyStore(receiver);
> Could you pass the other registers as arguments too and just do a
> DCHECK(AreContigious(...)) on them to ensure the assumptions made by the
> function hold.
> 
>
https://codereview.chromium.org/1721723002/diff/1/src/interpreter/bytecode-ge...
> src/interpreter/bytecode-generator.cc:1081:
> BuildKeyedSuperPropertyStore(receiver);
> Ditto (and for the others).

Thanks, done. Mistakenly did a rebase before uploading so there's a bit of chaff
in the patchset 1 only delta.

[rmcilroy, 2016-02-23 11:04:52]

Great, LGTM thanks!

[Michael Starzinger, 2016-02-23 11:46:29]

LGTM. Thanks!

[oth, 2016-02-23 15:21:00]

The CQ bit was checked by oth@chromium.org

[oth, 2016-02-23 15:21:00]

The patchset sent to the CQ was uploaded after l-g-t-m from
rmcilroy@chromium.org, mstarzinger@chromium.org
Link to the patchset: https://codereview.chromium.org/1721723002/#ps40001
(title: "Rebase.")

[commit-bot: I haz the power, 2016-02-23 15:21:09]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1721723002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1721723002/40001

[commit-bot: I haz the power, 2016-02-23 15:41:02]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-02-23 15:42:12]

Description was changed from

==========
[interpreter] Clean super property handling.

SuperPropertyArgumnets is less useful after deprecating strong mode.

BUG=v8:4280,v8:4682
LOG=N
==========

to

==========
[interpreter] Clean super property handling.

SuperPropertyArgumnets is less useful after deprecating strong mode.

BUG=v8:4280,v8:4682
LOG=N

Committed: https://crrev.com/bd9df50d75125ee2ad37b3d92c8f50f0a8b5f030
Cr-Commit-Position: refs/heads/master@{#34215}
==========

[commit-bot: I haz the power, 2016-02-23 15:42:13]

Patchset 3 (id:??) landed as
https://crrev.com/bd9df50d75125ee2ad37b3d92c8f50f0a8b5f030
Cr-Commit-Position: refs/heads/master@{#34215}