Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(232)

Unified Diff: src/interpreter/bytecode-generator.h

Issue 1721723002: [interpreter] Clean super property handling. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Rebase. Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | src/interpreter/bytecode-generator.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/interpreter/bytecode-generator.h
diff --git a/src/interpreter/bytecode-generator.h b/src/interpreter/bytecode-generator.h
index 46c4cc07807a707cc0bdd1a150474a5fd67a2358..4ef173890c0e880d0adbf63fcd48821dd31ec077 100644
--- a/src/interpreter/bytecode-generator.h
+++ b/src/interpreter/bytecode-generator.h
@@ -42,7 +42,6 @@ class BytecodeGenerator final : public AstVisitor {
class AccumulatorResultScope;
class RegisterResultScope;
class RegisterAllocationScope;
- class SuperPropertyArguments;
void MakeBytecodeBody();
@@ -94,18 +93,14 @@ class BytecodeGenerator final : public AstVisitor {
void VisitVariableAssignment(Variable* variable, Token::Value op,
FeedbackVectorSlot slot);
- void PrepareNamedSuperPropertyArguments(
- SuperPropertyReference* super_property, Handle<Name> name,
- SuperPropertyArguments* super_property_args);
- void PrepareKeyedSuperPropertyArguments(
- SuperPropertyReference* super_property, Expression* key,
- SuperPropertyArguments* super_property_args);
- void BuildNamedSuperPropertyLoad(SuperPropertyArguments* super_property_args);
- void BuildKeyedSuperPropertyLoad(SuperPropertyArguments* super_property_args);
- void BuildNamedSuperPropertyStore(
- SuperPropertyArguments* super_property_args);
- void BuildKeyedSuperPropertyStore(
- SuperPropertyArguments* super_property_args);
+ void BuildNamedSuperPropertyStore(Register receiver, Register home_object,
+ Register name, Register value);
+ void BuildKeyedSuperPropertyStore(Register receiver, Register home_object,
+ Register key, Register value);
+ void BuildNamedSuperPropertyLoad(Register receiver, Register home_object,
+ Register name);
+ void BuildKeyedSuperPropertyLoad(Register receiver, Register home_object,
+ Register key);
void BuildThrowIfHole(Handle<String> name);
void BuildThrowIfNotHole(Handle<String> name);
@@ -149,6 +144,7 @@ class BytecodeGenerator final : public AstVisitor {
void VisitForAccumulatorValue(Expression* expr);
void VisitForAccumulatorValueOrTheHole(Expression* expr);
MUST_USE_RESULT Register VisitForRegisterValue(Expression* expr);
+ void VisitForRegisterValue(Expression* expr, Register destination);
void VisitForEffect(Expression* expr);
// Methods for tracking and remapping register.
« no previous file with comments | « no previous file | src/interpreter/bytecode-generator.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698