scripts/slave/runtest.py - Issue 1721653003: Make sure CHROMIUM_OUTPUT_DIR is set from runtest.py

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: scripts/slave/runtest.py

Issue 1721653003: Make sure CHROMIUM_OUTPUT_DIR is set from runtest.py (Closed) Base URL: https://chromium.googlesource.com/chromium/tools/build.git@master

Patch Set: Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: scripts/slave/runtest.py

diff --git a/scripts/slave/runtest.py b/scripts/slave/runtest.py

index bd244c48651ef330d08ffbbeacf6b502571469e4..bb2cc03e47586f90ee3fe8ffeb6f19fa63609b58 100755

--- a/scripts/slave/runtest.py

+++ b/scripts/slave/runtest.py

@@ -1857,6 +1857,9 @@ def main():

# We will use this to accumulate overrides for the command under test,

# That we may not need or want for other support commands.

extra_env = {}

+ if not os.environ.get('CHROMIUM_OUTPUT_DIR') and options.target:

jbudorick 2016/03/11 16:28:14 Can we limit this to Android?

agrieve 2016/03/11 18:43:58 Done.

+ extra_env['CHROMIUM_OUTPUT_DIR'] = (

+ os.path.abspath(os.path.join(options.build_dir, options.target)))

# This option is used by sanitizer code. There is no corresponding command

# line flag.

« no previous file with comments | « no previous file | no next file » | no next file with comments »