Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(143)

Side by Side Diff: scripts/slave/runtest.py

Issue 1721653003: Make sure CHROMIUM_OUTPUT_DIR is set from runtest.py (Closed) Base URL: https://chromium.googlesource.com/chromium/tools/build.git@master
Patch Set: Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 #!/usr/bin/env python 1 #!/usr/bin/env python
2 # Copyright (c) 2012 The Chromium Authors. All rights reserved. 2 # Copyright (c) 2012 The Chromium Authors. All rights reserved.
3 # Use of this source code is governed by a BSD-style license that can be 3 # Use of this source code is governed by a BSD-style license that can be
4 # found in the LICENSE file. 4 # found in the LICENSE file.
5 5
6 """A tool used to run a Chrome test executable and process the output. 6 """A tool used to run a Chrome test executable and process the output.
7 7
8 This script is used by the buildbot slaves. It must be run from the outer 8 This script is used by the buildbot slaves. It must be run from the outer
9 build directory, e.g. chrome-release/build/. 9 build directory, e.g. chrome-release/build/.
10 10
(...skipping 1839 matching lines...) Expand 10 before | Expand all | Expand 10 after
1850 options.build_dir = build_directory.GetBuildOutputDirectory() 1850 options.build_dir = build_directory.GetBuildOutputDirectory()
1851 1851
1852 if options.pass_target and options.target: 1852 if options.pass_target and options.target:
1853 args.extend(['--target', options.target]) 1853 args.extend(['--target', options.target])
1854 if options.pass_build_dir: 1854 if options.pass_build_dir:
1855 args.extend(['--build-dir', options.build_dir]) 1855 args.extend(['--build-dir', options.build_dir])
1856 1856
1857 # We will use this to accumulate overrides for the command under test, 1857 # We will use this to accumulate overrides for the command under test,
1858 # That we may not need or want for other support commands. 1858 # That we may not need or want for other support commands.
1859 extra_env = {} 1859 extra_env = {}
1860 if not os.environ.get('CHROMIUM_OUTPUT_DIR') and options.target:
jbudorick 2016/03/11 16:28:14 Can we limit this to Android?
agrieve 2016/03/11 18:43:58 Done.
1861 extra_env['CHROMIUM_OUTPUT_DIR'] = (
1862 os.path.abspath(os.path.join(options.build_dir, options.target)))
1860 1863
1861 # This option is used by sanitizer code. There is no corresponding command 1864 # This option is used by sanitizer code. There is no corresponding command
1862 # line flag. 1865 # line flag.
1863 options.use_symbolization_script = False 1866 options.use_symbolization_script = False
1864 # Set up extra environment and args for sanitizer tools. 1867 # Set up extra environment and args for sanitizer tools.
1865 _ConfigureSanitizerTools(options, args, extra_env) 1868 _ConfigureSanitizerTools(options, args, extra_env)
1866 1869
1867 # Set the number of shards environment variables. 1870 # Set the number of shards environment variables.
1868 # NOTE: Chromium's test launcher will ignore these in favor of the command 1871 # NOTE: Chromium's test launcher will ignore these in favor of the command
1869 # line flags passed in _BuildTestBinaryCommand. 1872 # line flags passed in _BuildTestBinaryCommand.
(...skipping 68 matching lines...) Expand 10 before | Expand all | Expand 10 after
1938 finally: 1941 finally:
1939 if did_launch_dbus: 1942 if did_launch_dbus:
1940 # It looks like the command line argument --exit-with-session 1943 # It looks like the command line argument --exit-with-session
1941 # isn't working to clean up the spawned dbus-daemon. Kill it 1944 # isn't working to clean up the spawned dbus-daemon. Kill it
1942 # manually. 1945 # manually.
1943 _ShutdownDBus() 1946 _ShutdownDBus()
1944 1947
1945 1948
1946 if '__main__' == __name__: 1949 if '__main__' == __name__:
1947 sys.exit(main()) 1950 sys.exit(main())
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698