Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(268)

Issue 1721613002: Add JUnit tests for ImeThread activation (Closed)

Created:
4 years, 10 months ago by Changwan Ryu
Modified:
4 years, 3 months ago
CC:
asvitkine+watch_chromium.org, bondd+autofillwatch_chromium.org, browser-components-watch_chromium.org, chromium-reviews, creis+watch_chromium.org, darin-cc_chromium.org, estade+watch_chromium.org, jam, jbudorick+watch_chromium.org, jdonnelly+autofillwatch_chromium.org, mikecase+watch_chromium.org, mkwst+moarreviews-renderer_chromium.org, mlamouri+watch-content_chromium.org, nasko+codewatch_chromium.org, nona+watch_chromium.org, rouslan+autofill_chromium.org, shuchen+watch_chromium.org, James Su, vabr+watchlistautofill_chromium.org, yusukes+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add JUnit tests for ImeThread activation This can help verify and understand ImeThread activation process. BUG=588532 Committed: https://crrev.com/6369261d3a4060d52e538518bdffe16095619599 Cr-Commit-Position: refs/heads/master@{#418136}

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : adjusted to robolectric 3.0 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+301 lines, -4 lines) Patch
M content/public/android/BUILD.gn View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M content/public/android/java/src/org/chromium/content/browser/input/ThreadedInputConnectionFactory.java View 1 2 2 chunks +10 lines, -4 lines 0 comments Download
A content/public/android/junit/src/org/chromium/content/browser/input/ThreadedInputConnectionFactoryTest.java View 1 2 1 chunk +290 lines, -0 lines 0 comments Download

Messages

Total messages: 17 (10 generated)
Changwan Ryu
4 years, 3 months ago (2016-09-02 07:17:23 UTC) #7
aelias_OOO_until_Jul13
lgtm, this is pretty cool.
4 years, 3 months ago (2016-09-08 02:47:37 UTC) #8
Changwan Ryu
sievers@chromium.org: Please review changes in BUILD.gn. Thanks!
4 years, 3 months ago (2016-09-08 04:46:15 UTC) #10
no sievers
On 2016/09/08 04:46:15, Changwan Ryu wrote: > mailto:sievers@chromium.org: Please review changes in BUILD.gn. Thanks! lgtm
4 years, 3 months ago (2016-09-12 20:50:45 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/1721613002/40001
4 years, 3 months ago (2016-09-13 00:03:28 UTC) #13
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 3 months ago (2016-09-13 01:35:15 UTC) #15
commit-bot: I haz the power
4 years, 3 months ago (2016-09-13 01:39:28 UTC) #17
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/6369261d3a4060d52e538518bdffe16095619599
Cr-Commit-Position: refs/heads/master@{#418136}

Powered by Google App Engine
This is Rietveld 408576698