Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(107)

Issue 1721593002: Flip win_chromium_x64_rel_ng to MB, GN (Closed)

Created:
4 years, 10 months ago by Dirk Pranke
Modified:
4 years, 8 months ago
Reviewers:
jam, brucedawson
CC:
chromium-reviews, infra-reviews+build_chromium.org, kjellander-cc_chromium.org
Target Ref:
refs/heads/master
Project:
build
Visibility:
Public.

Description

Flip win_chromium_x64_rel_ng to MB, GN This flips the win_chromium_x64_rel_ng bot from mirroring 'Win x64 Builder' and 'Win 7 Tests x64 (1)' to mirroring 'Win x64 GN'; the net result is that we will get x64 GN coverage on the CQ (but lose GYP coverage). This is deemed to be an acceptable tradeoff and a good thing. R=brucedawson@chromium.org, jam@chromium.org BUG=581899

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -111 lines) Patch
M scripts/slave/recipe_modules/chromium_tests/trybots.py View 1 chunk +2 lines, -2 lines 0 comments Download
M scripts/slave/recipes/chromium_trybot.expected/full_tryserver_chromium_win_win_chromium_x64_rel_ng.json View 3 chunks +6 lines, -97 lines 0 comments Download
M scripts/slave/recipes/chromium_trybot.expected/full_tryserver_chromium_win_win_chromium_x64_rel_ng_analyze.json View 3 chunks +12 lines, -12 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 8 (1 generated)
Dirk Pranke
Please take a look, but note that this CL should not land until https://codereview.chromium.org/1720763002/ (the ...
4 years, 10 months ago (2016-02-22 00:11:32 UTC) #1
jam
lgtm
4 years, 10 months ago (2016-02-22 16:10:04 UTC) #2
brucedawson
On 2016/02/22 16:10:04, jam wrote: > lgtm Doesn't this change also depend on landing the ...
4 years, 10 months ago (2016-02-22 19:01:35 UTC) #3
Dirk Pranke
On 2016/02/22 19:01:35, brucedawson wrote: > On 2016/02/22 16:10:04, jam wrote: > > lgtm > ...
4 years, 10 months ago (2016-02-22 21:13:11 UTC) #4
brucedawson
What does MB mean in this context? Consider expanding TLA in description as 'MB' is ...
4 years, 10 months ago (2016-02-22 21:23:45 UTC) #5
Dirk Pranke
On 2016/02/22 21:23:45, brucedawson wrote: > What does MB mean in this context? Consider expanding ...
4 years, 10 months ago (2016-02-22 21:39:14 UTC) #6
Dirk Pranke
4 years, 8 months ago (2016-04-01 23:14:47 UTC) #8
Message was sent while issue was closed.
closing ... I plan to do this by flipping the main bots over to GN instead in a
week or so.

Powered by Google App Engine
This is Rietveld 408576698