Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1063)

Issue 1466563002: Remove the 'compile_targets' from 'Linux x64' on the chromium waterfall. (Closed)

Created:
5 years, 1 month ago by Dirk Pranke
Modified:
5 years, 1 month ago
CC:
chromium-reviews, infra-reviews+build_chromium.org, kjellander-cc_chromium.org, stip+watch_chromium.org
Target Ref:
refs/heads/master
Project:
build
Visibility:
Public.

Description

Remove the 'compile_targets' from 'Linux x64' on the chromium waterfall. The bot was previously specifying 'all' in compile_targets, which was getting added on to values specified in the src-side //testing/buildbot file, making it impossible to have the bot build anything other than all (i.e., to switch it to 'gn_all'). Since the src-side file also specifies 'all' at the moment, this is worse than redundant. TBR=phajdan.jr@chromium.org BUG=545480, 432959 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=297634

Patch Set 1 #

Total comments: 1

Messages

Total messages: 4 (1 generated)
Dirk Pranke
https://codereview.chromium.org/1466563002/diff/1/scripts/slave/recipes/chromium_trybot.expected/full_tryserver_chromium_linux_linux_chromium_archive_rel_ng.json File scripts/slave/recipes/chromium_trybot.expected/full_tryserver_chromium_linux_linux_chromium_archive_rel_ng.json (right): https://codereview.chromium.org/1466563002/diff/1/scripts/slave/recipes/chromium_trybot.expected/full_tryserver_chromium_linux_linux_chromium_archive_rel_ng.json#newcode204 scripts/slave/recipes/chromium_trybot.expected/full_tryserver_chromium_linux_linux_chromium_archive_rel_ng.json:204: "@@@STEP_LOG_LINE@analyze_details@ \"self.m.filter.compile_targets\": [], @@@", I'm not sure why this ...
5 years, 1 month ago (2015-11-20 02:27:14 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1466563002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1466563002/1
5 years, 1 month ago (2015-11-20 02:27:27 UTC) #3
commit-bot: I haz the power
5 years, 1 month ago (2015-11-20 02:30:26 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
http://src.chromium.org/viewvc/chrome?view=rev&revision=297634

Powered by Google App Engine
This is Rietveld 408576698