Remove Reflect.enumerate

Remove Reflect.enumerate

The Proxy enumerate trap and Reflect.enumerate are removed from the
ES2016 draft specification. This patch removes the Reflect.enumerate
function, and a follow-on patch will be responsible for the Proxy
trap changes.

R=adamk
LOG=Y
BUG=v8:4768
Committed: https://crrev.com/0b53b7d36b623b4b77f26079b54d388ea1dceff8
Cr-Commit-Position: refs/heads/master@{#34196}

[Dan Ehrenberg, 2016-02-19 23:47:13]

The CQ bit was checked by littledan@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-02-19 23:47:24]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1721453002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1721453002/1

[commit-bot: I haz the power, 2016-02-20 00:00:11]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-02-20 00:00:12]

Dry run: Try jobs failed on following builders:
  v8_mac_rel on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_mac_rel/builds/15749)

[adamk, 2016-02-20 00:06:15]

https://codereview.chromium.org/1721453002/diff/1/src/bootstrapper.cc
File src/bootstrapper.cc (right):

https://codereview.chromium.org/1721453002/diff/1/src/bootstrapper.cc#newcode...
src/bootstrapper.cc:2423: SimpleInstallFunction(reflect,
factory->apply_string(),
Hmm, seems like this is doing the same thing as the bits about reflect_apply and
reflect_construct over in ExportFromRuntime. Can we just do the work once?

[Dan Ehrenberg, 2016-02-20 00:12:28]

https://codereview.chromium.org/1721453002/diff/1/src/bootstrapper.cc
File src/bootstrapper.cc (right):

https://codereview.chromium.org/1721453002/diff/1/src/bootstrapper.cc#newcode...
src/bootstrapper.cc:2423: SimpleInstallFunction(reflect,
factory->apply_string(),
On 2016/02/20 at 00:06:14, adamk wrote:
> Hmm, seems like this is doing the same thing as the bits about reflect_apply
and reflect_construct over in ExportFromRuntime. Can we just do the work once?

The parser has desugarings into calls to reflect_apply and reflect_construct, so
I don't think I can just remove them. However, adding these two lines means that
I can remove the harmony-reflect.js file.

[adamk, 2016-02-20 00:23:55]

https://codereview.chromium.org/1721453002/diff/1/src/bootstrapper.cc
File src/bootstrapper.cc (right):

https://codereview.chromium.org/1721453002/diff/1/src/bootstrapper.cc#newcode...
src/bootstrapper.cc:2423: SimpleInstallFunction(reflect,
factory->apply_string(),
On 2016/02/20 00:12:28, Dan Ehrenberg wrote:
> On 2016/02/20 at 00:06:14, adamk wrote:
> > Hmm, seems like this is doing the same thing as the bits about reflect_apply
> and reflect_construct over in ExportFromRuntime. Can we just do the work once?
> 
> The parser has desugarings into calls to reflect_apply and reflect_construct,
so
> I don't think I can just remove them. However, adding these two lines means
that
> I can remove the harmony-reflect.js file.

Take a look at how object_is_extensible is handled, I think you ought to be able
to do that for these ones. In short, you capture the return value of this
SimpleInstallFunction, then set it in the native_context slot, and then change
the JS callers to use a '%' prefix when calling it and stop importing.

[Dan Ehrenberg, 2016-02-20 00:27:10]

On 2016/02/20 at 00:23:55, adamk wrote:
> https://codereview.chromium.org/1721453002/diff/1/src/bootstrapper.cc
> File src/bootstrapper.cc (right):
> 
>
https://codereview.chromium.org/1721453002/diff/1/src/bootstrapper.cc#newcode...
> src/bootstrapper.cc:2423: SimpleInstallFunction(reflect,
factory->apply_string(),
> On 2016/02/20 00:12:28, Dan Ehrenberg wrote:
> > On 2016/02/20 at 00:06:14, adamk wrote:
> > > Hmm, seems like this is doing the same thing as the bits about
reflect_apply
> > and reflect_construct over in ExportFromRuntime. Can we just do the work
once?
> > 
> > The parser has desugarings into calls to reflect_apply and
reflect_construct, so
> > I don't think I can just remove them. However, adding these two lines means
that
> > I can remove the harmony-reflect.js file.
> 
> Take a look at how object_is_extensible is handled, I think you ought to be
able to do that for these ones. In short, you capture the return value of this
SimpleInstallFunction, then set it in the native_context slot, and then change
the JS callers to use a '%' prefix when calling it and stop importing.

Yes, that'd be my plan when the flag is removed, but now that code only runs
when the --harmony_reflect flag is passed in.

[Dan Ehrenberg, 2016-02-20 00:27:36]

The CQ bit was checked by littledan@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-02-20 00:27:45]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1721453002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1721453002/20001

[commit-bot: I haz the power, 2016-02-20 00:41:06]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-02-20 00:41:07]

Dry run: Try jobs failed on following builders:
  v8_linux64_asan_rel on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_asan_rel/builds/...)

[Dan Ehrenberg, 2016-02-20 00:57:48]

The CQ bit was checked by littledan@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-02-20 00:57:56]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1721453002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1721453002/40001

[Dan Ehrenberg, 2016-02-20 00:58:55]

https://codereview.chromium.org/1721453002/diff/1/src/bootstrapper.cc
File src/bootstrapper.cc (right):

https://codereview.chromium.org/1721453002/diff/1/src/bootstrapper.cc#newcode...
src/bootstrapper.cc:2423: SimpleInstallFunction(reflect,
factory->apply_string(),
On 2016/02/20 at 00:23:55, adamk wrote:
> On 2016/02/20 00:12:28, Dan Ehrenberg wrote:
> > On 2016/02/20 at 00:06:14, adamk wrote:
> > > Hmm, seems like this is doing the same thing as the bits about
reflect_apply
> > and reflect_construct over in ExportFromRuntime. Can we just do the work
once?
> > 
> > The parser has desugarings into calls to reflect_apply and
reflect_construct, so
> > I don't think I can just remove them. However, adding these two lines means
that
> > I can remove the harmony-reflect.js file.
> 
> Take a look at how object_is_extensible is handled, I think you ought to be
able to do that for these ones. In short, you capture the return value of this
SimpleInstallFunction, then set it in the native_context slot, and then change
the JS callers to use a '%' prefix when calling it and stop importing.

Thanks for the reference; adopted that pattern. PTAL.

[adamk, 2016-02-20 01:04:42]

lgtm

[Dan Ehrenberg, 2016-02-20 01:05:00]

The CQ bit was unchecked by littledan@chromium.org

[Dan Ehrenberg, 2016-02-20 01:05:02]

The CQ bit was checked by littledan@chromium.org

[commit-bot: I haz the power, 2016-02-20 01:05:09]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1721453002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1721453002/40001

[commit-bot: I haz the power, 2016-02-20 01:16:11]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-02-20 01:16:11]

Try jobs failed on following builders:
  v8_linux_arm64_rel on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_arm64_rel/builds/1...)

[Dan Ehrenberg, 2016-02-20 01:50:24]

The CQ bit was checked by littledan@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-02-20 01:50:36]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1721453002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1721453002/60001

[commit-bot: I haz the power, 2016-02-20 02:04:05]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-02-20 02:04:06]

Dry run: Try jobs failed on following builders:
  v8_linux64_rel_ng on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_rel_ng/builds/1677)
  v8_linux64_rel_ng_triggered on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_rel_ng_triggered...)

[Dan Ehrenberg, 2016-02-22 18:48:30]

The CQ bit was checked by littledan@chromium.org

[Dan Ehrenberg, 2016-02-22 18:48:30]

The CQ bit was checked by littledan@chromium.org

[Dan Ehrenberg, 2016-02-22 18:48:30]

The patchset sent to the CQ was uploaded after l-g-t-m from adamk@chromium.org
Link to the patchset: https://codereview.chromium.org/1721453002/#ps80001
(title: "private symbols passes")

[Dan Ehrenberg, 2016-02-22 18:48:30]

The patchset sent to the CQ was uploaded after l-g-t-m from adamk@chromium.org
Link to the patchset: https://codereview.chromium.org/1721453002/#ps80001
(title: "private symbols passes")

[commit-bot: I haz the power, 2016-02-22 18:48:40]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1721453002/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1721453002/80001

[commit-bot: I haz the power, 2016-02-22 19:09:45]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2016-02-22 19:10:48]

Description was changed from

==========
Remove Reflect.enumerate

The Proxy enumerate trap and Reflect.enumerate are removed from the
ES2016 draft specification. This patch removes the Reflect.enumerate
function, and a follow-on patch will be responsible for the Proxy
trap changes.

R=adamk
LOG=Y
BUG=v8:4768
==========

to

==========
Remove Reflect.enumerate

The Proxy enumerate trap and Reflect.enumerate are removed from the
ES2016 draft specification. This patch removes the Reflect.enumerate
function, and a follow-on patch will be responsible for the Proxy
trap changes.

R=adamk
LOG=Y
BUG=v8:4768

Committed: https://crrev.com/0b53b7d36b623b4b77f26079b54d388ea1dceff8
Cr-Commit-Position: refs/heads/master@{#34196}
==========

[commit-bot: I haz the power, 2016-02-22 19:10:49]

Patchset 5 (id:??) landed as
https://crrev.com/0b53b7d36b623b4b77f26079b54d388ea1dceff8
Cr-Commit-Position: refs/heads/master@{#34196}