Remove Reflect.enumerate

src/bootstrapper.cc

 // Copyright 2014 the V8 project authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "src/bootstrapper.h"
 
 #include "src/accessors.h"
 #include "src/api-natives.h"
 #include "src/code-stubs.h"
 #include "src/extensions/externalize-string-extension.h"
@@ skipping 2402 matching lines @@
   Handle<JSGlobalObject> global(JSGlobalObject::cast(
       native_context()->global_object()));
   Handle<String> reflect_string = factory->NewStringFromStaticChars("Reflect");
   Handle<JSObject> reflect =
       factory->NewJSObject(isolate()->object_function(), TENURED);
   JSObject::AddProperty(global, reflect_string, reflect, DONT_ENUM);
 
   InstallFunction(reflect, define_property, factory->defineProperty_string());
   InstallFunction(reflect, delete_property, factory->deleteProperty_string());
 
+  SimpleInstallFunction(reflect, factory->apply_string(),

[adamk, 2016/02/20 00:06:14]

Hmm, seems like this is doing the same thing as the bits about reflect_apply and
reflect_construct over in ExportFromRuntime. Can we just do the work once?

[Dan Ehrenberg, 2016/02/20 00:12:28]

The parser has desugarings into calls to reflect_apply and reflect_construct, so
I don't think I can just remove them. However, adding these two lines means that
I can remove the harmony-reflect.js file.

[adamk, 2016/02/20 00:23:55]

Take a look at how object_is_extensible is handled, I think you ought to be able
to do that for these ones. In short, you capture the return value of this
SimpleInstallFunction, then set it in the native_context slot, and then change
the JS callers to use a '%' prefix when calling it and stop importing.

[Dan Ehrenberg, 2016/02/20 00:58:55]

Thanks for the reference; adopted that pattern. PTAL.

+                        Builtins::kReflectApply, 3, false);
+  SimpleInstallFunction(reflect, factory->construct_string(),
+                        Builtins::kReflectConstruct, 2, false);
   SimpleInstallFunction(reflect, factory->get_string(),
                         Builtins::kReflectGet, 2, false);
   SimpleInstallFunction(reflect, factory->getOwnPropertyDescriptor_string(),
                         Builtins::kReflectGetOwnPropertyDescriptor, 2, true);
   SimpleInstallFunction(reflect, factory->getPrototypeOf_string(),
                         Builtins::kReflectGetPrototypeOf, 1, true);
   SimpleInstallFunction(reflect, factory->has_string(),
                         Builtins::kReflectHas, 2, true);
   SimpleInstallFunction(reflect, factory->isExtensible_string(),
                         Builtins::kReflectIsExtensible, 1, true);
@@ skipping 1241 matching lines @@
 }
 
 
 // Called when the top-level V8 mutex is destroyed.
 void Bootstrapper::FreeThreadResources() {
   DCHECK(!IsActive());
 }
 
 }  // namespace internal
 }  // namespace v8