Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(536)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 17214003: Remove [InterfaceName] IDL attribute (Closed)

Created:
7 years, 6 months ago by do-not-use
Modified:
7 years, 6 months ago
CC:
blink-reviews, Nils Barth (inactive), jsbell+bindings_chromium.org, chromiumbugtracker_adobe.com, eae+blinkwatch, abarth-chromium, kinuko, marja+watch_chromium.org, dglazkov+blink, adamk+blink_chromium.org, Nate Chapin, lgombos
Visibility:
Public.

Description

Remove [InterfaceName] IDL attribute Get rid of remaining uses of [InterfaceName] IDL attribute, and replace by [ImplementedAs]. Also remove support from the scripts. BUG=242137 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=152530

Patch Set 1 #

Total comments: 1

Patch Set 2 : Fix try bot failures #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -202 lines) Patch
M Source/bindings/scripts/CodeGeneratorV8.pm View 6 chunks +5 lines, -15 lines 0 comments Download
M Source/bindings/scripts/IDLAttributes.txt View 1 chunk +0 lines, -1 line 0 comments Download
M Source/bindings/scripts/preprocess_idls.py View 1 chunk +1 line, -6 lines 0 comments Download
M Source/core/core.gypi View 4 chunks +3 lines, -3 lines 0 comments Download
D Source/core/dom/AnimationEvent.idl View 1 chunk +0 lines, -33 lines 0 comments Download
D Source/core/dom/DOMCoreException.idl View 1 chunk +0 lines, -79 lines 0 comments Download
A + Source/core/dom/DOMException.idl View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/dom/DOMExceptions.in View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/dom/EventNames.in View 1 1 chunk +1 line, -1 line 0 comments Download
M Source/core/dom/EventTargetFactory.in View 1 chunk +1 line, -1 line 0 comments Download
D Source/core/dom/NamedFlow.idl View 1 chunk +0 lines, -52 lines 0 comments Download
A + Source/core/dom/WebKitAnimationEvent.idl View 1 chunk +2 lines, -2 lines 0 comments Download
A + Source/core/dom/WebKitNamedFlow.idl View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/dom/WebKitNamedFlowCollection.idl View 1 chunk +3 lines, -3 lines 0 comments Download
M Source/modules/quota/StorageErrorCallback.idl View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (0 generated)
do-not-use
7 years, 6 months ago (2013-06-17 07:04:45 UTC) #1
haraken
This looks great. LGTM. https://codereview.chromium.org/17214003/diff/1/Source/core/dom/EventNames.in File Source/core/dom/EventNames.in (right): https://codereview.chromium.org/17214003/diff/1/Source/core/dom/EventNames.in#newcode30 Source/core/dom/EventNames.in:30: WebKitTransitionEvent interfaceName=TransitionEvent I don't fully ...
7 years, 6 months ago (2013-06-17 07:11:26 UTC) #2
do-not-use
On 2013/06/17 07:11:26, haraken wrote: > This looks great. LGTM. > > https://codereview.chromium.org/17214003/diff/1/Source/core/dom/EventNames.in > File ...
7 years, 6 months ago (2013-06-17 07:22:15 UTC) #3
haraken
> I guess so. Can I do that in a separate patch? Some need investigation ...
7 years, 6 months ago (2013-06-17 07:22:58 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ch.dumez@sisa.samsung.com/17214003/7001
7 years, 6 months ago (2013-06-17 07:49:31 UTC) #5
commit-bot: I haz the power
7 years, 6 months ago (2013-06-17 09:08:23 UTC) #6
Message was sent while issue was closed. 
Change committed as 152530

Powered by Google App Engine
This is Rietveld 408576698