Source/bindings/scripts/preprocess_idls.py - Issue 17214003: Remove [InterfaceName] IDL attribute

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/bindings/scripts/preprocess_idls.py

Issue 17214003: Remove [InterfaceName] IDL attribute (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Fix try bot failures Created 7 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/bindings/scripts/preprocess_idls.py

diff --git a/Source/bindings/scripts/preprocess_idls.py b/Source/bindings/scripts/preprocess_idls.py

index 8c5799dc6cacda7a50593eda2f655b3f892cd4c9..e9342121fcf7cdf95a4dfb7a36b31fa0831ef477 100644

--- a/Source/bindings/scripts/preprocess_idls.py

+++ b/Source/bindings/scripts/preprocess_idls.py

@@ -106,12 +106,7 @@ def generate_constructor_attribute_list(interface_name, extended_attributes):

else:

extended_string = ''

- # FIXME: Remove this once we remove [InterfaceName] IDL attribute, http://crbug.com/242137

- if 'InterfaceName' in extended_attributes:

- extended_interface_name = extended_attributes['InterfaceName']

- else:

- extended_interface_name = interface_name

- attribute_string = 'attribute %sConstructor %s' % (interface_name, extended_interface_name)

+ attribute_string = 'attribute %(interface_name)sConstructor %(interface_name)s' % {'interface_name': interface_name}

attributes_list = [extended_string + attribute_string]

# In addition to the regular property, for every [NamedConstructor]

« no previous file with comments | « Source/bindings/scripts/IDLAttributes.txt ('k') | Source/core/core.gypi » ('j') | no next file with comments »