Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(295)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1721223002: simplify/unify xferproc api (Closed)

Created:
4 years, 10 months ago by reed1
Modified:
4 years, 9 months ago
Reviewers:
herb_g, mtklein, f(malita)
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Patch Set 5 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+303 lines, -452 lines) Patch
M bench/Xfer4fBench.cpp View 1 2 3 chunks +40 lines, -39 lines 0 comments Download
M bench/XferU64Bench.cpp View 1 2 3 chunks +36 lines, -38 lines 0 comments Download
M gm/SkLinearBitmapPipelineGM.cpp View 1 2 2 chunks +2 lines, -3 lines 0 comments Download
D gm/xfer4f.cpp View 1 2 1 chunk +0 lines, -107 lines 0 comments Download
M include/core/SkXfermode.h View 1 2 2 chunks +18 lines, -30 lines 0 comments Download
M src/core/SkBitmapProcShader.h View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M src/core/SkBlitter_PM4f.cpp View 1 2 12 chunks +55 lines, -75 lines 0 comments Download
M src/core/SkSpriteBlitter4f.cpp View 1 2 3 5 chunks +12 lines, -20 lines 0 comments Download
M src/core/SkXfermode.cpp View 1 2 3 4 1 chunk +3 lines, -2 lines 0 comments Download
M src/core/SkXfermode4f.cpp View 1 2 10 chunks +58 lines, -92 lines 0 comments Download
M src/core/SkXfermodeU64.cpp View 1 2 7 chunks +78 lines, -45 lines 0 comments Download

Messages

Total messages: 13 (6 generated)
reed1
ptal
4 years, 10 months ago (2016-02-24 05:36:25 UTC) #3
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1721223002/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1721223002/80001
4 years, 10 months ago (2016-02-24 05:36:51 UTC) #5
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 10 months ago (2016-02-24 05:50:34 UTC) #7
mtklein
lgtm
4 years, 9 months ago (2016-02-24 13:53:13 UTC) #8
f(malita)
LGTM
4 years, 9 months ago (2016-02-24 14:15:25 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1721223002/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1721223002/80001
4 years, 9 months ago (2016-02-24 14:20:49 UTC) #11
commit-bot: I haz the power
4 years, 9 months ago (2016-02-24 14:21:39 UTC) #13
Message was sent while issue was closed. 
Committed patchset #5 (id:80001) as
https://skia.googlesource.com/skia/+/8f7b0b2d809510d4af4e6ff6f731bac78eded6c4

Powered by Google App Engine
This is Rietveld 408576698