Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(60)

Issue 17212: Update googletest (gtest) to 1.2.1 (Closed)

Created:
11 years, 11 months ago by M-A Ruel
Modified:
9 years, 7 months ago
CC:
chromium-reviews_googlegroups.com
Visibility:
Public.

Description

Update googletest (gtest) to 1.2.1 The main new thing is the ability to print the test's duration. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=7668

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+119 lines, -62 lines) Patch
M DEPS View 1 chunk +1 line, -1 line 0 comments Download
M media/media.xcodeproj/project.pbxproj View 2 2 chunks +2 lines, -2 lines 0 comments Download
M net/net.xcodeproj/project.pbxproj View 2 2 chunks +2 lines, -2 lines 0 comments Download
M testing/SConscript.gtest View 1 chunk +1 line, -0 lines 0 comments Download
M testing/gtest.vcproj View 1 chunk +109 lines, -57 lines 0 comments Download
M testing/gtest.xcodeproj/project.pbxproj View 4 chunks +4 lines, -0 lines 2 comments Download

Messages

Total messages: 4 (0 generated)
M-A Ruel
Pinkerton; the mac projects Pam; the rest
11 years, 11 months ago (2009-01-07 16:40:32 UTC) #1
M-A Ruel
Fixed the include order for the mac|release configuration too.
11 years, 11 months ago (2009-01-07 17:14:05 UTC) #2
pink (ping after 24hrs)
mac stuff LGTM with nits. http://codereview.chromium.org/17212/diff/207/17 File testing/gtest.xcodeproj/project.pbxproj (right): http://codereview.chromium.org/17212/diff/207/17#newcode64 Line 64: 14A5C8D80F13F7F500AA6CC7 /* gtest-test-part.cc ...
11 years, 11 months ago (2009-01-07 17:24:25 UTC) #3
Pam (message me for reviews)
11 years, 11 months ago (2009-01-07 18:20:46 UTC) #4
LGTM. The scons config I can't verify well, but it's good as far as my limited
knowledge goes.

- Pam

Powered by Google App Engine
This is Rietveld 408576698