core/src/fxcrt/fx_basic_wstring.cpp - Issue 1721073004: Switch from _DEBUG to NDEBUG.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: core/src/fxcrt/fx_basic_wstring.cpp

Issue 1721073004: Switch from _DEBUG to NDEBUG. (Closed) Base URL: https://pdfium.googlesource.com/pdfium@master

Patch Set: Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: core/src/fxcrt/fx_basic_wstring.cpp

diff --git a/core/src/fxcrt/fx_basic_wstring.cpp b/core/src/fxcrt/fx_basic_wstring.cpp

index 136edd073a5a4c7a3de8a426ce629e94b2988d49..dc2e7168a98842f9436d45c09cf49a3c22dedc2d 100644

--- a/core/src/fxcrt/fx_basic_wstring.cpp

+++ b/core/src/fxcrt/fx_basic_wstring.cpp

@@ -15,7 +15,7 @@

namespace {

-#if defined(_DEBUG)

+#if !defined(NDEBUG)

Tom Sepez 2016/02/23 00:38:44 dunno, I kinda prefer #ifndef NDEBUG, maybe becaus

bool IsValidCodePage(FX_WORD codepage) {

switch (codepage) {

case 0:

« no previous file with comments | « core/include/fxcrt/fx_system.h ('k') | fpdfsdk/src/javascript/global.cpp » ('j') | no next file with comments »