Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(28)

Unified Diff: core/include/fxcrt/fx_system.h

Issue 1721073004: Switch from _DEBUG to NDEBUG. (Closed) Base URL: https://pdfium.googlesource.com/pdfium@master
Patch Set: Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | core/src/fxcrt/fx_basic_wstring.cpp » ('j') | core/src/fxcrt/fx_basic_wstring.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: core/include/fxcrt/fx_system.h
diff --git a/core/include/fxcrt/fx_system.h b/core/include/fxcrt/fx_system.h
index f4798680d3898d3eb576b82597748e026edf9afa..e85be8893e2ec61b0edf943a8a0d0974083ea3bc 100644
--- a/core/include/fxcrt/fx_system.h
+++ b/core/include/fxcrt/fx_system.h
@@ -81,10 +81,6 @@ typedef wchar_t FX_WCHAR; // Keep, maybe bad platform wchars.
// TODO(palmer): it should be a |size_t|, or at least unsigned.
typedef int FX_STRSIZE;
-#if defined(DEBUG) && !defined(_DEBUG)
-#define _DEBUG
-#endif
-
#ifndef TRUE
#define TRUE 1
#endif
@@ -104,10 +100,10 @@ static_assert(FALSE == false, "false_needs_to_be_false");
#define FXSYS_assert assert
#ifndef ASSERT
-#ifdef _DEBUG
-#define ASSERT FXSYS_assert
-#else
+#if defined(NDEBUG)
#define ASSERT(a)
+#else
+#define ASSERT FXSYS_assert
#endif
#endif
« no previous file with comments | « no previous file | core/src/fxcrt/fx_basic_wstring.cpp » ('j') | core/src/fxcrt/fx_basic_wstring.cpp » ('J')

Powered by Google App Engine
This is Rietveld 408576698