Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1064)

Issue 172103008: Pepper: Clean up PpapiDispatcher parent classes. (Closed)

Created:
6 years, 10 months ago by teravest
Modified:
6 years, 10 months ago
CC:
chromium-reviews
Visibility:
Public.

Description

Pepper: Clean up PpapiDispatcher parent classes. This change modifies PpapiDispatcher to inherit IPC::Listener and IPC::Sender instead of ProxyChannel directly. This cleans up the class hierarchy a bit. BUG= R=dmichael@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=252108

Patch Set 1 #

Total comments: 1

Patch Set 2 : exit() on channel error #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -7 lines) Patch
M ppapi/proxy/plugin_main_nacl.cc View 1 7 chunks +26 lines, -7 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
teravest
I think this is easier to read, and the class wasn't using many features of ...
6 years, 10 months ago (2014-02-19 19:20:40 UTC) #1
dmichael (off chromium)
Thanks, that does seem better. lgtm https://codereview.chromium.org/172103008/diff/1/ppapi/proxy/plugin_main_nacl.cc File ppapi/proxy/plugin_main_nacl.cc (right): https://codereview.chromium.org/172103008/diff/1/ppapi/proxy/plugin_main_nacl.cc#newcode207 ppapi/proxy/plugin_main_nacl.cc:207: channel_.reset(); I wonder ...
6 years, 10 months ago (2014-02-19 19:23:51 UTC) #2
teravest
The CQ bit was checked by teravest@chromium.org
6 years, 10 months ago (2014-02-19 20:31:08 UTC) #3
teravest
On Wed, Feb 19, 2014 at 12:23 PM, <dmichael@chromium.org> wrote: > Thanks, that does seem ...
6 years, 10 months ago (2014-02-19 20:31:14 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/teravest@chromium.org/172103008/60001
6 years, 10 months ago (2014-02-19 20:49:20 UTC) #5
teravest
6 years, 10 months ago (2014-02-19 21:59:23 UTC) #6
Message was sent while issue was closed.
Committed patchset #2 manually as r252108 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698