Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(180)

Unified Diff: ppapi/proxy/plugin_main_nacl.cc

Issue 172103008: Pepper: Clean up PpapiDispatcher parent classes. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: exit() on channel error Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ppapi/proxy/plugin_main_nacl.cc
diff --git a/ppapi/proxy/plugin_main_nacl.cc b/ppapi/proxy/plugin_main_nacl.cc
index 90ebfd484874e18fe77da9f949eca9f187bd3e04..852ff4e4a7f05250faf067d83e4c7003c472a371 100644
--- a/ppapi/proxy/plugin_main_nacl.cc
+++ b/ppapi/proxy/plugin_main_nacl.cc
@@ -2,6 +2,8 @@
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
+#include <unistd.h>
+
#include <map>
#include <set>
@@ -12,6 +14,7 @@
// ViewMsgLog et al. functions.
#include "base/command_line.h"
+#include "base/memory/scoped_ptr.h"
#include "base/message_loop/message_loop.h"
#include "base/strings/string_number_conversions.h"
#include "base/synchronization/waitable_event.h"
@@ -56,9 +59,10 @@ namespace {
// This class manages communication between the plugin and the browser, and
// manages the PluginDispatcher instances for communication between the plugin
// and the renderer.
-class PpapiDispatcher : public ProxyChannel,
- public PluginDispatcher::PluginDelegate,
- public PluginProxyDelegate {
+class PpapiDispatcher : public PluginDispatcher::PluginDelegate,
+ public PluginProxyDelegate,
+ public IPC::Listener,
+ public IPC::Sender {
public:
explicit PpapiDispatcher(scoped_refptr<base::MessageLoopProxy> io_loop);
@@ -86,6 +90,10 @@ class PpapiDispatcher : public ProxyChannel,
// IPC::Listener implementation.
virtual bool OnMessageReceived(const IPC::Message& message) OVERRIDE;
+ virtual void OnChannelError() OVERRIDE;
+
+ // IPC::Sender implementation
+ virtual bool Send(IPC::Message* message) OVERRIDE;
private:
void OnMsgInitializeNaClDispatcher(const ppapi::PpapiNaClPluginArgs& args);
@@ -98,6 +106,7 @@ class PpapiDispatcher : public ProxyChannel,
uint32 next_plugin_dispatcher_id_;
scoped_refptr<base::MessageLoopProxy> message_loop_;
base::WaitableEvent shutdown_event_;
+ scoped_ptr<IPC::SyncChannel> channel_;
};
PpapiDispatcher::PpapiDispatcher(scoped_refptr<base::MessageLoopProxy> io_loop)
@@ -110,11 +119,13 @@ PpapiDispatcher::PpapiDispatcher(scoped_refptr<base::MessageLoopProxy> io_loop)
"NaCl IPC", base::FileDescriptor(NACL_CHROME_DESC_BASE, false));
// We don't have/need a PID since handle sharing happens outside of the
// NaCl sandbox.
- InitWithChannel(this, base::kNullProcessId, channel_handle,
- false); // Channel is server.
- channel()->AddFilter(new ppapi::proxy::PluginMessageFilter(
+ channel_.reset(new IPC::SyncChannel(
+ channel_handle, IPC::Channel::MODE_SERVER, this,
+ GetIPCMessageLoop(), true, GetShutdownEvent()));
+
+ channel_->AddFilter(new ppapi::proxy::PluginMessageFilter(
NULL, PluginGlobals::Get()->resource_reply_thread_registrar()));
- channel()->AddFilter(
+ channel_->AddFilter(
new tracing::ChildTraceMessageFilter(message_loop_.get()));
}
@@ -194,6 +205,14 @@ bool PpapiDispatcher::OnMessageReceived(const IPC::Message& msg) {
return true;
}
+void PpapiDispatcher::OnChannelError() {
+ exit(1);
+}
+
+bool PpapiDispatcher::Send(IPC::Message* msg) {
+ return channel_->Send(msg);
+}
+
void PpapiDispatcher::OnMsgInitializeNaClDispatcher(
const ppapi::PpapiNaClPluginArgs& args) {
static bool command_line_and_logging_initialized = false;
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698