Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(132)

Issue 1721003003: Fix multiple assignment of "visibility" in generate_library_loader.gni (Closed)

Created:
4 years, 10 months ago by spang
Modified:
4 years, 10 months ago
Reviewers:
Nico, Paweł Hajdan Jr.
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix multiple assignment of "visibility" in generate_library_loader.gni If the invoker has visibility set, it will be assigned twice, and rejected by GN. Remove the second assignment. TBR=thakis Committed: https://crrev.com/6ad2f470bac33901adc68c86e1863cde5985838e Cr-Commit-Position: refs/heads/master@{#377090}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -3 lines) Patch
M tools/generate_library_loader/generate_library_loader.gni View 1 chunk +0 lines, -3 lines 0 comments Download

Messages

Total messages: 16 (8 generated)
spang
4 years, 10 months ago (2016-02-22 22:10:03 UTC) #2
Paweł Hajdan Jr.
LGTM
4 years, 10 months ago (2016-02-23 17:02:40 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1721003003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1721003003/1
4 years, 10 months ago (2016-02-23 17:52:48 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/149121)
4 years, 10 months ago (2016-02-23 18:19:45 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1721003003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1721003003/1
4 years, 10 months ago (2016-02-23 21:12:01 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 10 months ago (2016-02-23 21:24:40 UTC) #13
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/6ad2f470bac33901adc68c86e1863cde5985838e Cr-Commit-Position: refs/heads/master@{#377090}
4 years, 10 months ago (2016-02-23 21:25:40 UTC) #15
Nico
4 years, 10 months ago (2016-02-23 21:39:00 UTC) #16
Message was sent while issue was closed.
can you create a tools/generate_library_loader/OWNER file please?

Powered by Google App Engine
This is Rietveld 408576698