Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(860)

Side by Side Diff: tools/generate_library_loader/generate_library_loader.gni

Issue 1721003003: Fix multiple assignment of "visibility" in generate_library_loader.gni (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright 2014 The Chromium Authors. All rights reserved. 1 # Copyright 2014 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 # This template makes a stub for a Linux system library that dynamically loads 5 # This template makes a stub for a Linux system library that dynamically loads
6 # it at runtime. 6 # it at runtime.
7 7
8 # name: Name to use for the value of the --name arg. 8 # name: Name to use for the value of the --name arg.
9 # output_h/output_cc: Names for the generated header/cc file with no dir. 9 # output_h/output_cc: Names for the generated header/cc file with no dir.
10 # header: header file to process. Example: "<foo/bar.h>" 10 # header: header file to process. Example: "<foo/bar.h>"
11 # functions: List of strings for functions to process. 11 # functions: List of strings for functions to process.
12 # config: (optional) Label of the config generated by pkgconfig. 12 # config: (optional) Label of the config generated by pkgconfig.
13 # bundled_header: (optional) 13 # bundled_header: (optional)
14 template("generate_library_loader") { 14 template("generate_library_loader") {
15 output_h = "$root_gen_dir/library_loaders/" + invoker.output_h 15 output_h = "$root_gen_dir/library_loaders/" + invoker.output_h
16 output_cc = "$root_gen_dir/library_loaders/" + invoker.output_cc 16 output_cc = "$root_gen_dir/library_loaders/" + invoker.output_cc
17 17
18 action_visibility = [ ":$target_name" ] 18 action_visibility = [ ":$target_name" ]
19 action("${target_name}_loader") { 19 action("${target_name}_loader") {
20 visibility = action_visibility 20 visibility = action_visibility
21 21
22 script = "//tools/generate_library_loader/generate_library_loader.py" 22 script = "//tools/generate_library_loader/generate_library_loader.py"
23 if (defined(invoker.visibility)) {
24 visibility = invoker.visibility
25 }
26 23
27 outputs = [ 24 outputs = [
28 output_h, 25 output_h,
29 output_cc, 26 output_cc,
30 ] 27 ]
31 28
32 args = [ 29 args = [
33 "--name", 30 "--name",
34 invoker.name, 31 invoker.name,
35 "--output-h", 32 "--output-h",
(...skipping 25 matching lines...) Expand all
61 } 58 }
62 sources = [ 59 sources = [
63 output_cc, 60 output_cc,
64 output_h, 61 output_h,
65 ] 62 ]
66 public_deps = [ 63 public_deps = [
67 ":${target_name}_loader", 64 ":${target_name}_loader",
68 ] 65 ]
69 } 66 }
70 } 67 }
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698