Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(79)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1720973002: [DevTools] Add device type to custom device presets. (Closed)

Created:
4 years, 10 months ago by dgozman
Modified:
4 years, 10 months ago
Reviewers:
pfeldman
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, sergeyv+blink_chromium.org, pfeldman, kozyatinskiy+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[DevTools] Add device type to custom device presets. BUG=587841 Committed: https://crrev.com/4b6f9cfbf319a0208da51034caa4908c21fa61d6 Cr-Commit-Position: refs/heads/master@{#376821}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+38 lines, -39 lines) Patch
M third_party/WebKit/Source/devtools/front_end/emulation/DeviceModeModel.js View 1 chunk +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/emulation/DeviceModeToolbar.js View 2 chunks +5 lines, -12 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/emulation/DevicesSettingsTab.js View 4 chunks +23 lines, -21 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/emulation/devicesSettingsTab.css View 1 chunk +6 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
dgozman
Take a look please.
4 years, 10 months ago (2016-02-22 18:35:26 UTC) #2
pfeldman
lgtm
4 years, 10 months ago (2016-02-22 19:38:27 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1720973002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1720973002/1
4 years, 10 months ago (2016-02-22 19:55:03 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 10 months ago (2016-02-22 21:54:32 UTC) #6
commit-bot: I haz the power
4 years, 10 months ago (2016-02-22 21:56:18 UTC) #8
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/4b6f9cfbf319a0208da51034caa4908c21fa61d6
Cr-Commit-Position: refs/heads/master@{#376821}

Powered by Google App Engine
This is Rietveld 408576698