third_party/WebKit/Source/devtools/front_end/emulation/DeviceModeToolbar.js - Issue 1720973002: [DevTools] Add device type to custom device presets.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/devtools/front_end/emulation/DeviceModeToolbar.js

Issue 1720973002: [DevTools] Add device type to custom device presets. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/devtools/front_end/emulation/DeviceModeModel.js ('k') | third_party/WebKit/Source/devtools/front_end/emulation/DevicesSettingsTab.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/devtools/front_end/emulation/DeviceModeToolbar.js

diff --git a/third_party/WebKit/Source/devtools/front_end/emulation/DeviceModeToolbar.js b/third_party/WebKit/Source/devtools/front_end/emulation/DeviceModeToolbar.js

index 372ef3e2647c235b5b70a2f5dd31aaf8e82208f9..b3ed9a7bdb7f2e1160b05dc4e3209e58aa62550c 100644

--- a/third_party/WebKit/Source/devtools/front_end/emulation/DeviceModeToolbar.js

+++ b/third_party/WebKit/Source/devtools/front_end/emulation/DeviceModeToolbar.js

@@ -235,10 +235,10 @@ WebInspector.DeviceModeToolbar.prototype = {

_appendUserAgentMenuItems: function(contextMenu)

{

var uaSetting = this._model.uaSetting();

- appendUAItem(WebInspector.UIString("Mobile"), WebInspector.DeviceModeModel.UA.Mobile);

- appendUAItem(WebInspector.UIString("Mobile (no touch)"), WebInspector.DeviceModeModel.UA.MobileNoTouch);

- appendUAItem(WebInspector.UIString("Desktop"), WebInspector.DeviceModeModel.UA.Desktop);

- appendUAItem(WebInspector.UIString("Desktop (touch)"), WebInspector.DeviceModeModel.UA.DesktopTouch);

+ appendUAItem(WebInspector.DeviceModeModel.UA.Mobile, WebInspector.DeviceModeModel.UA.Mobile);

+ appendUAItem(WebInspector.DeviceModeModel.UA.MobileNoTouch, WebInspector.DeviceModeModel.UA.MobileNoTouch);

+ appendUAItem(WebInspector.DeviceModeModel.UA.Desktop, WebInspector.DeviceModeModel.UA.Desktop);

+ appendUAItem(WebInspector.DeviceModeModel.UA.DesktopTouch, WebInspector.DeviceModeModel.UA.DesktopTouch);

/**

* @param {string} title

@@ -506,14 +506,7 @@ WebInspector.DeviceModeToolbar.prototype = {

var uaType = this._model.appliedUserAgentType();

if (uaType !== this._cachedUaType) {

- var uaTitle = WebInspector.UIString("Desktop");

- if (uaType === WebInspector.DeviceModeModel.UA.Mobile)

- uaTitle = WebInspector.UIString("Mobile");

- if (uaType === WebInspector.DeviceModeModel.UA.MobileNoTouch)

- uaTitle = WebInspector.UIString("Mobile (no touch)");

- if (uaType === WebInspector.DeviceModeModel.UA.DesktopTouch)

- uaTitle = WebInspector.UIString("Desktop (touch)");

- this._uaItem.setText(uaTitle);

+ this._uaItem.setText(uaType);

this._cachedUaType = uaType;

}