swarming: always append task's OS dimension to step name

swarming: always append task's OS dimension to step name

This helps detect errors - some of them in this CL (findit),
other in e.g. https://codereview.chromium.org/1722573002 .

BUG=none

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=298925

[Paweł Hajdan Jr., 2016-02-22 12:52:53]

phajdan.jr@chromium.org changed reviewers:
+ estaab@chromium.org, maruel@chromium.org

[Paweł Hajdan Jr., 2016-02-22 12:53:01]

The CQ bit was checked by phajdan.jr@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-02-22 12:53:08]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1720873002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1720873002/1

[commit-bot: I haz the power, 2016-02-22 12:56:58]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-02-22 12:56:59]

Dry run: This issue passed the CQ dry run.

[Paweł Hajdan Jr., 2016-02-22 13:12:31]

Forgot to add context. Please review:

maruel: entire CL (see commit message for rationale)
estaab: this changes step names for uploading to test-results; just wanted to
check with you before proceeding

[M-A Ruel, 2016-02-22 16:11:49]

+stgao@ for findit.

I'm fine with the change, I'm ambivalent if my request should be a follow up or
if we should pack this one liner in since all the expectations have to be
updated anyway.

https://codereview.chromium.org/1720873002/diff/1/scripts/slave/recipe_module...
File scripts/slave/recipe_modules/swarming/api.py (right):

https://codereview.chromium.org/1720873002/diff/1/scripts/slave/recipe_module...
scripts/slave/recipe_modules/swarming/api.py:479: tags.add('name:' + task.title)
The more I was thinking about it, while it's not related to this CL but since
this CL already updates most expectations, do you mind doing a split(' ')[0]
here?

The goal would have to have tags "name:base_unittests" and
"stepname:base_unittests (with patch) on Ubuntu 14.04".

It's kind of a hack but it would get us going to be able to better analyze the
load per test. wdyt?

[estaab, 2016-02-22 19:35:42]

On 2016/02/22 at 13:12:31, phajdan.jr wrote:
> Forgot to add context. Please review:
> 
> maruel: entire CL (see commit message for rationale)
> estaab: this changes step names for uploading to test-results; just wanted to
check with you before proceeding

lgtm

test-results looks for a specific pattern to get the "test type":
https://code.google.com/p/chromium/codesearch#chromium/infra/appengine/test_r...

I *think* this CL won't break the current logic so lgtm from my side.

[Paweł Hajdan Jr., 2016-02-23 18:14:25]

The CQ bit was checked by phajdan.jr@chromium.org

[commit-bot: I haz the power, 2016-02-23 18:14:30]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1720873002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1720873002/1

[commit-bot: I haz the power, 2016-02-23 18:18:54]

Description was changed from

==========
swarming: always append task's OS dimension to step name

This helps detect errors - some of them in this CL (findit),
other in e.g. https://codereview.chromium.org/1722573002 .

BUG=none
==========

to

==========
swarming: always append task's OS dimension to step name

This helps detect errors - some of them in this CL (findit),
other in e.g. https://codereview.chromium.org/1722573002 .

BUG=none

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=298925
==========

[commit-bot: I haz the power, 2016-02-23 18:18:55]

Committed patchset #1 (id:1) as
http://src.chromium.org/viewvc/chrome?view=rev&revision=298925

[Paweł Hajdan Jr., 2016-02-24 16:24:19]

https://codereview.chromium.org/1720873002/diff/1/scripts/slave/recipe_module...
File scripts/slave/recipe_modules/swarming/api.py (right):

https://codereview.chromium.org/1720873002/diff/1/scripts/slave/recipe_module...
scripts/slave/recipe_modules/swarming/api.py:479: tags.add('name:' + task.title)
On 2016/02/22 at 16:11:49, M-A Ruel wrote:
> The more I was thinking about it, while it's not related to this CL but since
this CL already updates most expectations, do you mind doing a split(' ')[0]
here?
> 
> The goal would have to have tags "name:base_unittests" and
"stepname:base_unittests (with patch) on Ubuntu 14.04".
> 
> It's kind of a hack but it would get us going to be able to better analyze the
load per test. wdyt?

Sure, uploaded https://codereview.chromium.org/1733683002 .

[stgao, 2016-02-24 19:06:06]

stgao@chromium.org changed reviewers:
+ stgao@chromium.org

[stgao, 2016-02-24 19:06:07]

lgtm for findit (sorry for delay, was in a summit)

And many thanks for the fix.