Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1864)

Unified Diff: scripts/slave/recipes/findit/chromium/test.py

Issue 1720873002: swarming: always append task's OS dimension to step name (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/tools/build
Patch Set: Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: scripts/slave/recipes/findit/chromium/test.py
diff --git a/scripts/slave/recipes/findit/chromium/test.py b/scripts/slave/recipes/findit/chromium/test.py
index e87267c9b6ae4f13a98f06e0e98825bfb9e37081..c5046879efa661e5ea598dd6c4f00a89bfa07543 100644
--- a/scripts/slave/recipes/findit/chromium/test.py
+++ b/scripts/slave/recipes/findit/chromium/test.py
@@ -245,7 +245,7 @@ def GenTests(api):
'tests': tests,
'use_analyze': use_analyze,
}
- return api.properties(**properties)
+ return api.properties(**properties) + api.platform.name(platform_name)
def simulated_gtest_output(failed_test_names=(), passed_test_names=()):
cur_iteration_data = {}
@@ -312,7 +312,7 @@ def GenTests(api):
})
) +
api.override_step_data(
- 'test r1.affected_tests (r1)',
+ 'test r1.affected_tests (r1) on Windows-7-SP1',
simulated_gtest_output(passed_test_names=['Test.One'])
)
)
@@ -362,7 +362,7 @@ def GenTests(api):
},
})) +
api.override_step_data(
- 'test r1.gl_tests (r1)',
+ 'test r1.gl_tests (r1) on Windows-7-SP1',
simulated_gtest_output(
failed_test_names=['Test.One', 'Test.Two', 'Test.Three'])
)
@@ -383,7 +383,7 @@ def GenTests(api):
},
})) +
api.override_step_data(
- 'test r1.gl_tests (r1)',
+ 'test r1.gl_tests (r1) on Windows-7-SP1',
simulated_gtest_output(
passed_test_names=['Test.One', 'Test.Two', 'Test.Three'])
)
@@ -404,7 +404,7 @@ def GenTests(api):
},
})) +
api.override_step_data(
- 'test r1.gl_tests (r1)',
+ 'test r1.gl_tests (r1) on Windows-7-SP1',
simulated_gtest_output(
failed_test_names=['Test.One', 'Test.Two'],
passed_test_names=['Test.Three'])

Powered by Google App Engine
This is Rietveld 408576698