third_party/WebKit/Source/core/svg/graphics/SVGImage.cpp - Issue 1720853002: Remove Image::computeIntrinsicDimensions()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/svg/graphics/SVGImage.cpp

Issue 1720853002: Remove Image::computeIntrinsicDimensions() (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@add-and-use-updateconcretesize-upload

Patch Set: Avoid using the size of the error image. Null-check in ImageResource saved the day in previous patc… Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/svg/graphics/SVGImage.h ('k') | third_party/WebKit/Source/core/svg/graphics/SVGImageForContainer.h » ('j') | third_party/WebKit/Source/platform/graphics/GeneratedImage.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/svg/graphics/SVGImage.cpp

diff --git a/third_party/WebKit/Source/core/svg/graphics/SVGImage.cpp b/third_party/WebKit/Source/core/svg/graphics/SVGImage.cpp

index aaccff3a99f7516d92b398f7d484a43982bbf4e2..bfdb3ff702b6382718a5f6a3691d69c07f3aa018 100644

--- a/third_party/WebKit/Source/core/svg/graphics/SVGImage.cpp

+++ b/third_party/WebKit/Source/core/svg/graphics/SVGImage.cpp

@@ -401,21 +401,6 @@ FrameView* SVGImage::frameView() const

return toLocalFrame(m_page->mainFrame())->view();

}

-void SVGImage::computeIntrinsicDimensions(FloatSize& intrinsicSize, FloatSize& intrinsicRatio)

- SVGSVGElement* rootElement = svgRootElement(m_page.get());

- if (!rootElement)

- return;

- intrinsicSize = FloatSize(rootElement->intrinsicWidth(), rootElement->intrinsicHeight());

- if (rootElement->preserveAspectRatio()->currentValue()->align() == SVGPreserveAspectRatio::SVG_PRESERVEASPECTRATIO_NONE)

- return;

- intrinsicRatio = rootElement->viewBox()->currentValue()->value().size();

- if (intrinsicRatio.isEmpty())

- intrinsicRatio = intrinsicSize;

// FIXME: support CatchUpAnimation = CatchUp.

void SVGImage::startAnimation(CatchUpAnimation)

{