third_party/WebKit/Source/core/style/StyleInvalidImage.h - Issue 1720853002: Remove Image::computeIntrinsicDimensions()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/style/StyleInvalidImage.h

Issue 1720853002: Remove Image::computeIntrinsicDimensions() (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@add-and-use-updateconcretesize-upload

Patch Set: Avoid using the size of the error image. Null-check in ImageResource saved the day in previous patc… Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/style/StyleImage.h ('k') | third_party/WebKit/Source/core/style/StylePendingImage.h » ('j') | third_party/WebKit/Source/platform/graphics/GeneratedImage.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/style/StyleInvalidImage.h

diff --git a/third_party/WebKit/Source/core/style/StyleInvalidImage.h b/third_party/WebKit/Source/core/style/StyleInvalidImage.h

index 79e7899398ef39f94b4686e036b5abcd16de51ea..2b60fa3a7e30181e0f2f53689b9cdb4c67b846fe 100644

--- a/third_party/WebKit/Source/core/style/StyleInvalidImage.h

+++ b/third_party/WebKit/Source/core/style/StyleInvalidImage.h

@@ -25,7 +25,6 @@ public:

LayoutSize imageSize(const LayoutObject*, float /*multiplier*/, const LayoutSize& /*defaultObjectSize*/) const override { return LayoutSize(); }

bool imageHasRelativeSize() const override { return false; }

- void computeIntrinsicDimensions(const LayoutObject*, FloatSize& /* intrinsicSize */, FloatSize& /* intrinsicRatio */) override { }

bool usesImageContainerSize() const override { return false; }

void addClient(LayoutObject*) override { }

void removeClient(LayoutObject*) override { }