Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(16)

Issue 1720603002: Revert of mojo: Get mojo:leveldb and mojo:filesystem compiled into content. (Closed)

Created:
4 years, 10 months ago by Ben Goodger (Google)
Modified:
4 years, 10 months ago
Reviewers:
jam, Elliot Glaysher
CC:
chromium-reviews, creis+watch_chromium.org, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, nasko+codewatch_chromium.org, jam, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin-cc_chromium.org, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of mojo: Get mojo:leveldb and mojo:filesystem compiled into content. (patchset #11 id:200001 of https://codereview.chromium.org/1708253004/ ) Reason for revert: incomplete dependencies stated in gyp causing compile flake on waterfall Original issue's description: > mojo: Get mojo:leveldb and mojo:filesystem compiled into content. > > BUG=585587 > > Committed: https://crrev.com/d42c4081fdb8fa382d5b0af101a45106b4d12d4c > Cr-Commit-Position: refs/heads/master@{#376606} TBR=jam@chromium.org,erg@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=585587 Committed: https://crrev.com/60fafa71dec876a42126df7174289fb59bb9ac30 Cr-Commit-Position: refs/heads/master@{#376645}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+169 lines, -283 lines) Patch
M components/filesystem/BUILD.gn View 4 chunks +3 lines, -4 lines 0 comments Download
M components/filesystem/file_system_app.h View 1 chunk +29 lines, -0 lines 0 comments Download
M components/filesystem/file_system_app.cc View 2 chunks +66 lines, -2 lines 0 comments Download
M components/filesystem/file_system_impl.h View 2 chunks +3 lines, -1 line 0 comments Download
M components/filesystem/file_system_impl.cc View 3 chunks +7 lines, -3 lines 0 comments Download
D components/filesystem/filesystem.gyp View 1 chunk +0 lines, -67 lines 0 comments Download
M components/leveldb/BUILD.gn View 3 chunks +3 lines, -6 lines 0 comments Download
D components/leveldb/leveldb.gyp View 1 chunk +0 lines, -63 lines 0 comments Download
M components/leveldb/leveldb_app.h View 3 chunks +14 lines, -2 lines 0 comments Download
M components/leveldb/leveldb_app.cc View 3 chunks +44 lines, -3 lines 0 comments Download
D components/leveldb/leveldb_service_impl.h View 1 chunk +0 lines, -37 lines 0 comments Download
D components/leveldb/leveldb_service_impl.cc View 1 chunk +0 lines, -58 lines 0 comments Download
M content/browser/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M content/content_browser.gypi View 1 chunk +0 lines, -2 lines 0 comments Download
D mojo/mojo_platform_handle.gyp View 1 chunk +0 lines, -34 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
Ben Goodger (Google)
Created Revert of mojo: Get mojo:leveldb and mojo:filesystem compiled into content.
4 years, 10 months ago (2016-02-20 15:29:00 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1720603002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1720603002/1
4 years, 10 months ago (2016-02-20 15:29:10 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 10 months ago (2016-02-20 15:29:55 UTC) #3
commit-bot: I haz the power
4 years, 10 months ago (2016-02-20 15:31:04 UTC) #5
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/60fafa71dec876a42126df7174289fb59bb9ac30
Cr-Commit-Position: refs/heads/master@{#376645}

Powered by Google App Engine
This is Rietveld 408576698