third_party/WebKit/LayoutTests/animations/keyword-composition-crash.html - Issue 1720403002: Alternative syntax for element.animate list of keyframes

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/LayoutTests/animations/keyword-composition-crash.html

Issue 1720403002: Alternative syntax for element.animate list of keyframes (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@animations-keyframeeffect-api

Patch Set: Change to error types and how offset/composite are handled, plus minor fixes Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « no previous file | third_party/WebKit/LayoutTests/web-animations-api/element-animate-list-of-keyframes.html » ('j') | third_party/WebKit/LayoutTests/web-animations-api/element-animate-list-of-keyframes.html » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/LayoutTests/animations/keyword-composition-crash.html

diff --git a/third_party/WebKit/LayoutTests/animations/keyword-composition-crash.html b/third_party/WebKit/LayoutTests/animations/keyword-composition-crash.html

index 2611fdb89dad6f262238be05a307253dc7116060..5b93f9ef1636b9bd921bf1de89dfa0928eaf03b8 100644

--- a/third_party/WebKit/LayoutTests/animations/keyword-composition-crash.html

+++ b/third_party/WebKit/LayoutTests/animations/keyword-composition-crash.html

@@ -3,8 +3,8 @@

test(() => {

- target.animate({position: 'absolute'}, {fill: 'forwards'});

- target.animate({position: 'static', composite: 'add'}, {fill: 'forwards'});

+ target.animate([{position: 'absolute'}], {fill: 'forwards'});

+ target.animate([{position: 'static', composite: 'add'}], {fill: 'forwards'});

getComputedStyle(target).position;

}, "Don't crash when compositing keyword animations.");

</script>