third_party/WebKit/LayoutTests/animations/keyword-composition-crash.html - Issue 1720403002: Alternative syntax for element.animate list of keyframes

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/LayoutTests/animations/keyword-composition-crash.html

Issue 1720403002: Alternative syntax for element.animate list of keyframes (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@animations-keyframeeffect-api

Patch Set: Change to error types and how offset/composite are handled, plus minor fixes Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « no previous file | third_party/WebKit/LayoutTests/web-animations-api/element-animate-list-of-keyframes.html » ('j') | third_party/WebKit/LayoutTests/web-animations-api/element-animate-list-of-keyframes.html » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 <script src="../resources/testharness.js"></script>	1 <script src="../resources/testharness.js"></script>

2 <script src="../resources/testharnessreport.js"></script>	2 <script src="../resources/testharnessreport.js"></script>

3 <div id="target"></div>	3 <div id="target"></div>

4 <script>	4 <script>

5 test(() => {	5 test(() => {

6 target.animate({position: 'absolute'}, {fill: 'forwards'});	6 target.animate([{position: 'absolute'}], {fill: 'forwards'});

7 target.animate({position: 'static', composite: 'add'}, {fill: 'forwards'});	7 target.animate([{position: 'static', composite: 'add'}], {fill: 'forwards'});

8 getComputedStyle(target).position;	8 getComputedStyle(target).position;

9 }, "Don't crash when compositing keyword animations.");	9 }, "Don't crash when compositing keyword animations.");

10 </script>	10 </script>

OLD	NEW