Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(372)

Issue 1720193002: - Fix --run-fullsnapshot flag processing issue in non product mode. (Closed)

Created:
4 years, 10 months ago by siva
Modified:
4 years, 10 months ago
Reviewers:
rmacnak
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

- Fix --run-fullsnapshot flag processing issue in non product mode. - Adjust status files for product mode issues (Process.run, SpawnUri, test expecting line numbers) R=rmacnak@google.com Committed: https://github.com/dart-lang/sdk/commit/809c205cae949fbcbd546c68914e3119c28f4343

Patch Set 1 #

Patch Set 2 : self-code-review #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -3 lines) Patch
M runtime/bin/main.cc View 1 chunk +3 lines, -1 line 0 comments Download
M runtime/tests/vm/vm.status View 1 1 chunk +6 lines, -0 lines 0 comments Download
M samples/samples.status View 1 chunk +1 line, -1 line 0 comments Download
M tests/co19/co19-runtime.status View 1 chunk +4 lines, -1 line 0 comments Download
M tests/corelib/corelib.status View 1 chunk +4 lines, -0 lines 0 comments Download
M tests/isolate/isolate.status View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
siva
4 years, 10 months ago (2016-02-22 21:52:18 UTC) #2
siva
4 years, 10 months ago (2016-02-22 22:46:29 UTC) #3
rmacnak
lgtm
4 years, 10 months ago (2016-02-22 23:20:47 UTC) #4
siva
4 years, 10 months ago (2016-02-22 23:33:38 UTC) #6
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
809c205cae949fbcbd546c68914e3119c28f4343 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698