Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(580)

Side by Side Diff: runtime/bin/main.cc

Issue 1720193002: - Fix --run-fullsnapshot flag processing issue in non product mode. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: self-code-review Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | runtime/tests/vm/vm.status » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 #include <stdlib.h> 5 #include <stdlib.h>
6 #include <string.h> 6 #include <string.h>
7 #include <stdio.h> 7 #include <stdio.h>
8 8
9 #include "include/dart_api.h" 9 #include "include/dart_api.h"
10 #include "include/dart_tools_api.h" 10 #include "include/dart_tools_api.h"
(...skipping 393 matching lines...) Expand 10 before | Expand all | Expand 10 after
404 return ProcessSnapshotOptionHelper(filename, 404 return ProcessSnapshotOptionHelper(filename,
405 &generate_full_snapshot_after_run); 405 &generate_full_snapshot_after_run);
406 } 406 }
407 407
408 408
409 static bool ProcessRunFullSnapshotOption( 409 static bool ProcessRunFullSnapshotOption(
410 const char* filename, CommandLineOptions* vm_options) { 410 const char* filename, CommandLineOptions* vm_options) {
411 #ifndef DART_PRODUCT_BINARY 411 #ifndef DART_PRODUCT_BINARY
412 Log::PrintErr("Full Application snapshots can only be be run with" 412 Log::PrintErr("Full Application snapshots can only be be run with"
413 " dart_product\n"); 413 " dart_product\n");
414 #endif 414 return false;
415 #else
415 return ProcessSnapshotOptionHelper(filename, &run_full_snapshot); 416 return ProcessSnapshotOptionHelper(filename, &run_full_snapshot);
417 #endif // defined(DART_PRODUCT_BINARY)
416 } 418 }
417 419
418 420
419 static bool ProcessEnableVmServiceOption(const char* option_value, 421 static bool ProcessEnableVmServiceOption(const char* option_value,
420 CommandLineOptions* vm_options) { 422 CommandLineOptions* vm_options) {
421 ASSERT(option_value != NULL); 423 ASSERT(option_value != NULL);
422 424
423 if (!ExtractPortAndIP(option_value, 425 if (!ExtractPortAndIP(option_value,
424 &vm_service_server_port, 426 &vm_service_server_port,
425 &vm_service_server_ip, 427 &vm_service_server_ip,
(...skipping 1238 matching lines...) Expand 10 before | Expand all | Expand 10 after
1664 Platform::Exit(Process::GlobalExitCode()); 1666 Platform::Exit(Process::GlobalExitCode());
1665 } 1667 }
1666 1668
1667 } // namespace bin 1669 } // namespace bin
1668 } // namespace dart 1670 } // namespace dart
1669 1671
1670 int main(int argc, char** argv) { 1672 int main(int argc, char** argv) {
1671 dart::bin::main(argc, argv); 1673 dart::bin::main(argc, argv);
1672 UNREACHABLE(); 1674 UNREACHABLE();
1673 } 1675 }
OLDNEW
« no previous file with comments | « no previous file | runtime/tests/vm/vm.status » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698