Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1720053002:
Update subscription instructions for Monorail. (Closed)
DescriptionUpdate subscription instructions for Monorail.
Committed: https://crrev.com/12372dcba97c093259993fd9fbc4096c3e385cd3
Cr-Commit-Position: refs/heads/master@{#376783}
Patch Set 1 #
Total comments: 8
Patch Set 2 : address mmenke feedback #Patch Set 3 : change to not include subcomponents #
Dependent Patchsets: Messages
Total messages: 13 (3 generated)
eroman@chromium.org changed reviewers: + mmenke@chromium.org
LGTM! Meant to do this, but then forgot. https://codereview.chromium.org/1720053002/diff/1/net/docs/bug-triage-suggest... File net/docs/bug-triage-suggested-workflow.md (right): https://codereview.chromium.org/1720053002/diff/1/net/docs/bug-triage-suggest... net/docs/bug-triage-suggested-workflow.md:92: tracker, click on "Profile", then go to "Saved Queries". Profile -> Issues? It's to the right of the search box. Think it's better to mention its location there, since that's more convenient, relative to where people spend their time. https://codereview.chromium.org/1720053002/diff/1/net/docs/bug-triage-suggest... net/docs/bug-triage-suggested-workflow.md:95: * Query: component:Internals>Network Hrm...My old queries were converted to component=Internals>Network. Is there a difference between the two? https://codereview.chromium.org/1720053002/diff/1/net/docs/bug-triage-suggest... net/docs/bug-triage-suggested-workflow.md:95: * Query: component:Internals>Network Should we mention a name being needed? I've had great luck with "Billy Bob", so maybe we should suggest that?
(FWIW I am also working on a CL to transform all the Cr-* labels to components in the documentation)
https://codereview.chromium.org/1720053002/diff/1/net/docs/bug-triage-suggest... File net/docs/bug-triage-suggested-workflow.md (right): https://codereview.chromium.org/1720053002/diff/1/net/docs/bug-triage-suggest... net/docs/bug-triage-suggested-workflow.md:92: tracker, click on "Profile", then go to "Saved Queries". On 2016/02/22 18:52:19, mmenke wrote: > Profile -> Issues? It's to the right of the search box. Think it's better to > mention its location there, since that's more convenient, relative to where > people spend their time. Done. https://codereview.chromium.org/1720053002/diff/1/net/docs/bug-triage-suggest... net/docs/bug-triage-suggested-workflow.md:95: * Query: component:Internals>Network On 2016/02/22 18:52:19, mmenke wrote: > Hrm...My old queries were converted to component=Internals>Network. Is there a > difference between the two? Yes there is: It is explained on https://bugs.chromium.org/p/chromium/issues/searchtips component:UI will search essentially UI>* whereas component=UI will search just UI So a bug on UI>Foobar would fire on the colon version, but not the equal version. https://codereview.chromium.org/1720053002/diff/1/net/docs/bug-triage-suggest... net/docs/bug-triage-suggested-workflow.md:95: * Query: component:Internals>Network On 2016/02/22 18:52:19, mmenke wrote: > Should we mention a name being needed? I've had great luck with "Billy Bob", so > maybe we should suggest that? Or alternately mmenke rulz? Done: "Network Bug Triage"
https://codereview.chromium.org/1720053002/diff/1/net/docs/bug-triage-suggest... File net/docs/bug-triage-suggested-workflow.md (right): https://codereview.chromium.org/1720053002/diff/1/net/docs/bug-triage-suggest... net/docs/bug-triage-suggested-workflow.md:95: * Query: component:Internals>Network On 2016/02/22 19:04:14, eroman wrote: > On 2016/02/22 18:52:19, mmenke wrote: > > Hrm...My old queries were converted to component=Internals>Network. Is there > a > > difference between the two? > > Yes there is: > > It is explained on https://bugs.chromium.org/p/chromium/issues/searchtips > > component:UI will search essentially UI>* > > whereas > > component=UI will search just UI > > So a bug on UI>Foobar would fire on the colon version, but not the equal > version. Hrm...I don't think the triager should subscribe to all sublabels?
https://codereview.chromium.org/1720053002/diff/1/net/docs/bug-triage-suggest... File net/docs/bug-triage-suggested-workflow.md (right): https://codereview.chromium.org/1720053002/diff/1/net/docs/bug-triage-suggest... net/docs/bug-triage-suggested-workflow.md:95: * Query: component:Internals>Network On 2016/02/22 19:12:03, mmenke wrote: > On 2016/02/22 19:04:14, eroman wrote: > > On 2016/02/22 18:52:19, mmenke wrote: > > > Hrm...My old queries were converted to component=Internals>Network. Is > there > > a > > > difference between the two? > > > > Yes there is: > > > > It is explained on https://bugs.chromium.org/p/chromium/issues/searchtips > > > > component:UI will search essentially UI>* > > > > whereas > > > > component=UI will search just UI > > > > So a bug on UI>Foobar would fire on the colon version, but not the equal > > version. > > Hrm...I don't think the triager should subscribe to all sublabels? Done.
On 2016/02/22 19:17:58, eroman wrote: > https://codereview.chromium.org/1720053002/diff/1/net/docs/bug-triage-suggest... > File net/docs/bug-triage-suggested-workflow.md (right): > > https://codereview.chromium.org/1720053002/diff/1/net/docs/bug-triage-suggest... > net/docs/bug-triage-suggested-workflow.md:95: * Query: > component:Internals>Network > On 2016/02/22 19:12:03, mmenke wrote: > > On 2016/02/22 19:04:14, eroman wrote: > > > On 2016/02/22 18:52:19, mmenke wrote: > > > > Hrm...My old queries were converted to component=Internals>Network. Is > > there > > > a > > > > difference between the two? > > > > > > Yes there is: > > > > > > It is explained on https://bugs.chromium.org/p/chromium/issues/searchtips > > > > > > component:UI will search essentially UI>* > > > > > > whereas > > > > > > component=UI will search just UI > > > > > > So a bug on UI>Foobar would fire on the colon version, but not the equal > > > version. > > > > Hrm...I don't think the triager should subscribe to all sublabels? > > Done. LGTM!
The CQ bit was checked by eroman@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1720053002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1720053002/40001
Message was sent while issue was closed.
Committed patchset #3 (id:40001)
Message was sent while issue was closed.
Description was changed from ========== Update subscription instructions for Monorail. ========== to ========== Update subscription instructions for Monorail. Committed: https://crrev.com/12372dcba97c093259993fd9fbc4096c3e385cd3 Cr-Commit-Position: refs/heads/master@{#376783} ==========
Message was sent while issue was closed.
Patchset 3 (id:??) landed as https://crrev.com/12372dcba97c093259993fd9fbc4096c3e385cd3 Cr-Commit-Position: refs/heads/master@{#376783} |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
