Trigger options width update when option text changes.

Trigger options width update when option text changes.

Previously this was triggered by doing a full host subtree recalc on
shadow redistribution, but that recalc was removed as an optimization.

R=tkent@chromium.org
BUG=588585
Committed: https://crrev.com/2f66709d65f2acccc6f3296709d77342f336c382
Cr-Commit-Position: refs/heads/master@{#376880}

[rune, 2016-02-22 10:01:15]

The CQ bit was checked by rune@opera.com to run a CQ dry run

[commit-bot: I haz the power, 2016-02-22 10:03:24]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1719873002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1719873002/1

[rune, 2016-02-22 10:04:14]

ptal

[commit-bot: I haz the power, 2016-02-22 13:05:39]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-02-22 13:05:39]

Dry run: This issue passed the CQ dry run.

[tkent, 2016-02-22 23:18:39]

https://codereview.chromium.org/1719873002/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/html/HTMLSelectElement.cpp (right):

https://codereview.chromium.org/1719873002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/html/HTMLSelectElement.cpp:442:
setOptionsChangedOnLayoutObject();
The |OptionsChanged| flag is referred only in
LayoutMenuList::updateFromElement().  Who calls updateFromElement() in this
case?

[rune, 2016-02-23 00:41:42]

https://codereview.chromium.org/1719873002/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/html/HTMLSelectElement.cpp (right):

https://codereview.chromium.org/1719873002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/html/HTMLSelectElement.cpp:442:
setOptionsChangedOnLayoutObject();
On 2016/02/22 23:18:38, tkent wrote:
> The |OptionsChanged| flag is referred only in
> LayoutMenuList::updateFromElement().  Who calls updateFromElement() in this
> case?

HTMLFormControlElement::didRecalcStyle() which is called for the
HTMLSelectElement from Element::recalcStyle(). And there is a recalc style
traversing past the select because the option text node needs a style recalc.

[tkent, 2016-02-23 00:42:45]

lgtm

[rune, 2016-02-23 00:44:15]

The CQ bit was checked by rune@opera.com

[commit-bot: I haz the power, 2016-02-23 00:46:27]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1719873002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1719873002/1

[commit-bot: I haz the power, 2016-02-23 00:56:40]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-02-23 00:58:47]

Description was changed from

==========
Trigger options width update when option text changes.

Previously this was triggered by doing a full host subtree recalc on
shadow redistribution, but that recalc was removed as an optimization.

R=tkent@chromium.org
BUG=588585
==========

to

==========
Trigger options width update when option text changes.

Previously this was triggered by doing a full host subtree recalc on
shadow redistribution, but that recalc was removed as an optimization.

R=tkent@chromium.org
BUG=588585

Committed: https://crrev.com/2f66709d65f2acccc6f3296709d77342f336c382
Cr-Commit-Position: refs/heads/master@{#376880}
==========

[commit-bot: I haz the power, 2016-02-23 00:58:48]

Patchset 1 (id:??) landed as
https://crrev.com/2f66709d65f2acccc6f3296709d77342f336c382
Cr-Commit-Position: refs/heads/master@{#376880}