Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(252)

Side by Side Diff: third_party/WebKit/Source/core/html/HTMLSelectElement.cpp

Issue 1719873002: Trigger options width update when option text changes. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « third_party/WebKit/LayoutTests/fast/forms/select/option-relayout-modified-text-expected.txt ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2010 Nokia Corporation and/or its subsidiary(-ies). 2 * Copyright (C) 2010 Nokia Corporation and/or its subsidiary(-ies).
3 * Copyright (C) 1999 Lars Knoll (knoll@kde.org) 3 * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
4 * (C) 1999 Antti Koivisto (koivisto@kde.org) 4 * (C) 1999 Antti Koivisto (koivisto@kde.org)
5 * (C) 2001 Dirk Mueller (mueller@kde.org) 5 * (C) 2001 Dirk Mueller (mueller@kde.org)
6 * Copyright (C) 2004, 2005, 2006, 2007, 2009, 2010, 2011 Apple Inc. All rights reserved. 6 * Copyright (C) 2004, 2005, 2006, 2007, 2009, 2010, 2011 Apple Inc. All rights reserved.
7 * (C) 2006 Alexey Proskuryakov (ap@nypop.com) 7 * (C) 2006 Alexey Proskuryakov (ap@nypop.com)
8 * Copyright (C) 2010 Google Inc. All rights reserved. 8 * Copyright (C) 2010 Google Inc. All rights reserved.
9 * Copyright (C) 2009 Torch Mobile Inc. All rights reserved. (http://www.torchmo bile.com/) 9 * Copyright (C) 2009 Torch Mobile Inc. All rights reserved. (http://www.torchmo bile.com/)
10 * 10 *
(...skipping 421 matching lines...) Expand 10 before | Expand all | Expand 10 after
432 setRecalcListItems(); 432 setRecalcListItems();
433 setNeedsValidityCheck(); 433 setNeedsValidityCheck();
434 m_lastOnChangeSelection.clear(); 434 m_lastOnChangeSelection.clear();
435 435
436 HTMLFormControlElementWithState::childrenChanged(change); 436 HTMLFormControlElementWithState::childrenChanged(change);
437 } 437 }
438 438
439 void HTMLSelectElement::optionElementChildrenChanged() 439 void HTMLSelectElement::optionElementChildrenChanged()
440 { 440 {
441 setNeedsValidityCheck(); 441 setNeedsValidityCheck();
442 setOptionsChangedOnLayoutObject();
tkent 2016/02/22 23:18:38 The |OptionsChanged| flag is referred only in Layo
rune 2016/02/23 00:41:42 HTMLFormControlElement::didRecalcStyle() which is
442 443
443 if (layoutObject()) { 444 if (layoutObject()) {
444 if (AXObjectCache* cache = layoutObject()->document().existingAXObjectCa che()) 445 if (AXObjectCache* cache = layoutObject()->document().existingAXObjectCa che())
445 cache->childrenChanged(this); 446 cache->childrenChanged(this);
446 } 447 }
447 } 448 }
448 449
449 void HTMLSelectElement::accessKeyAction(bool sendMouseEvents) 450 void HTMLSelectElement::accessKeyAction(bool sendMouseEvents)
450 { 451 {
451 focus(); 452 focus();
(...skipping 1565 matching lines...) Expand 10 before | Expand all | Expand 10 after
2017 m_popupIsVisible = false; 2018 m_popupIsVisible = false;
2018 m_popup = nullptr; 2019 m_popup = nullptr;
2019 } 2020 }
2020 2021
2021 void HTMLSelectElement::resetTypeAheadSessionForTesting() 2022 void HTMLSelectElement::resetTypeAheadSessionForTesting()
2022 { 2023 {
2023 m_typeAhead.resetSession(); 2024 m_typeAhead.resetSession();
2024 } 2025 }
2025 2026
2026 } // namespace blink 2027 } // namespace blink
OLDNEW
« no previous file with comments | « third_party/WebKit/LayoutTests/fast/forms/select/option-relayout-modified-text-expected.txt ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698