Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(465)

Issue 1719803002: Resolve heap-use-after-free in CFX_WideString::~CFX_WideString() (Closed)

Created:
4 years, 10 months ago by jun_fang
Modified:
4 years, 10 months ago
Reviewers:
Tom Sepez, Lei Zhang
CC:
pdfium-reviews_googlegroups.com, Jim Wang, kai_jing
Base URL:
https://pdfium.googlesource.com/pdfium.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Resolve heap-use-after-free in CFX_WideString::~CFX_WideString() BUG=pdfium:402 R=tsepez@chromium.org Committed: https://pdfium.googlesource.com/pdfium/+/2c115d829d3560fd5082500c552dfe38850881ec

Patch Set 1 #

Patch Set 2 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -10 lines) Patch
M xfa/include/fwl/lightwidget/listbox.h View 1 chunk +1 line, -1 line 0 comments Download
M xfa/src/fwl/src/lightwidget/listbox.cpp View 1 chunk +1 line, -9 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
jun_fang
Hi Tom and Lei, Please start to review this CL. Thanks!
4 years, 10 months ago (2016-02-22 02:41:03 UTC) #2
Tom Sepez
lgtm Yup.
4 years, 10 months ago (2016-02-22 17:21:56 UTC) #3
jun_fang
4 years, 10 months ago (2016-02-23 01:36:34 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
2c115d829d3560fd5082500c552dfe38850881ec (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698