xfa/include/fwl/lightwidget/listbox.h - Issue 1719803002: Resolve heap-use-after-free in CFX_WideString::~CFX_WideString()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: xfa/include/fwl/lightwidget/listbox.h

Issue 1719803002: Resolve heap-use-after-free in CFX_WideString::~CFX_WideString() (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@master

Patch Set: Rebase Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: xfa/include/fwl/lightwidget/listbox.h

diff --git a/xfa/include/fwl/lightwidget/listbox.h b/xfa/include/fwl/lightwidget/listbox.h

index 09bc018a632e81fd552065183c27d6f792ee0d28..b30f0f67396a024d841ebd3362966f67bab8972c 100644

--- a/xfa/include/fwl/lightwidget/listbox.h

+++ b/xfa/include/fwl/lightwidget/listbox.h

@@ -26,7 +26,7 @@ class CFWL_ListBox : public CFWL_Widget {

FWL_HLISTITEM AddString(const CFX_WideStringC& wsAdd,

FX_BOOL bSelect = FALSE);

FX_BOOL DeleteString(FWL_HLISTITEM hItem);

- FX_BOOL DeleteAll();

+ void DeleteAll();

int32_t CountSelItems();

FWL_HLISTITEM GetSelItem(int32_t nIndexSel);

int32_t GetSelIndex(int32_t nIndex);

« no previous file with comments | « no previous file | xfa/src/fwl/src/lightwidget/listbox.cpp » ('j') | no next file with comments »