NSView cleanup for CoreAnimation

NSView cleanup for CoreAnimation

Make devtools place the contents view as a child of the devtools view,
so that the contents appears on top of the devtools.

Add instances of ScopedNSDisableScreenUpdates while adjusting views,
and replace some instances of [NSWindow disableScreenUpdatesUntilFlush]
with this more explicit mechanism.

BUG=245900
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=252537

[ccameron, 2014-02-20 20:51:57]

After we finish the switch to CA, we should be able to remove all remaining
instances of disableScreenUpdatesUntilFlush. I find the scoped-disable much
easier to reason about (without the change in the tab strip, we had to rely on a
disable-until-flush in the RWHVMac code, which had to know which views would be
added or removed first).

I added a branch on CoreAnimation to the devtools code because I don't want to
verify that the arrangement I added actually works without CoreAnimation (it
appears to, but I'd rather not risk non-CA distractions).

[dgozman, 2014-02-20 21:29:51]

devtools lgtm

https://codereview.chromium.org/171973004/diff/1/chrome/browser/ui/cocoa/dev_...
File chrome/browser/ui/cocoa/dev_tools_controller.mm (right):

https://codereview.chromium.org/171973004/diff/1/chrome/browser/ui/cocoa/dev_...
chrome/browser/ui/cocoa/dev_tools_controller.mm:71: if
(CoreAnimationIsEnabled()) {
Do you plan to discard the old without-core-animation way entirely once you are
ready?

[ccameron, 2014-02-20 21:31:09]

Thanks!

https://codereview.chromium.org/171973004/diff/1/chrome/browser/ui/cocoa/dev_...
File chrome/browser/ui/cocoa/dev_tools_controller.mm (right):

https://codereview.chromium.org/171973004/diff/1/chrome/browser/ui/cocoa/dev_...
chrome/browser/ui/cocoa/dev_tools_controller.mm:71: if
(CoreAnimationIsEnabled()) {
On 2014/02/20 21:29:51, dgozman wrote:
> Do you plan to discard the old without-core-animation way entirely once you
are
> ready?

Yes, hopefully all non-CA code will be deleted before M35 branches.

[Avi (use Gerrit), 2014-02-20 22:00:32]

LGTM

[ccameron, 2014-02-20 22:14:06]

Thanks!

[ccameron, 2014-02-20 22:14:09]

The CQ bit was checked by ccameron@chromium.org

[commit-bot: I haz the power, 2014-02-20 22:16:32]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/ccameron@chromium.org/171973004/1

[commit-bot: I haz the power, 2014-02-20 22:37:02]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-02-20 22:37:02]

Retried try job too often on win_rel for step(s) base_unittests, browser_tests,
interactive_ui_tests, net_unittests, unit_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&nu...

[ccameron, 2014-02-21 00:53:27]

The CQ bit was checked by ccameron@chromium.org

[commit-bot: I haz the power, 2014-02-21 00:55:25]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/ccameron@chromium.org/171973004/1

[commit-bot: I haz the power, 2014-02-21 06:01:55]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-02-21 06:01:56]

Retried try job too often on win_rel for step(s) browser_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&nu...

[ccameron, 2014-02-21 09:38:29]

The CQ bit was checked by ccameron@chromium.org

[commit-bot: I haz the power, 2014-02-21 09:38:37]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/ccameron@chromium.org/171973004/1

[commit-bot: I haz the power, 2014-02-21 11:21:12]

Change committed as 252537