Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(657)

Unified Diff: chrome/browser/ui/cocoa/tabs/tab_strip_controller.mm

Issue 171973004: NSView cleanup for CoreAnimation (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/cocoa/tabs/tab_strip_controller.mm
diff --git a/chrome/browser/ui/cocoa/tabs/tab_strip_controller.mm b/chrome/browser/ui/cocoa/tabs/tab_strip_controller.mm
index 7c33924c21800c7320227988ea5a109f097e30dc..41e8bdf5030cc79402bc57e9809bd9d69f6ef3d7 100644
--- a/chrome/browser/ui/cocoa/tabs/tab_strip_controller.mm
+++ b/chrome/browser/ui/cocoa/tabs/tab_strip_controller.mm
@@ -71,6 +71,7 @@
#include "ui/base/resource/resource_bundle.h"
#include "ui/base/theme_provider.h"
#include "ui/gfx/image/image.h"
+#include "ui/gfx/mac/scoped_ns_disable_screen_updates.h"
using base::UserMetricsAction;
using content::OpenURLParams;
@@ -613,9 +614,11 @@ NSImage* Overlay(NSImage* ground, NSImage* overlay, CGFloat alpha) {
NSInteger index = [self indexFromModelIndex:modelIndex];
TabContentsController* controller = [tabContentsArray_ objectAtIndex:index];
+ // Make sure we do not draw any transient arrangements of views.
+ gfx::ScopedNSDisableScreenUpdates ns_disabler;
// Make sure that any layers that move are not animated to their new
// positions.
- ScopedCAActionDisabler disabler;
+ ScopedCAActionDisabler ca_disabler;
// Resize the new view to fit the window. Calling |view| may lazily
// instantiate the TabContentsController from the nib. Until we call

Powered by Google App Engine
This is Rietveld 408576698