third_party/WebKit/Source/platform/image-decoders/jpeg/JPEGImageDecoder.h - Issue 1719533002: Modify YUV codecs to match Skia's API change

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/image-decoders/jpeg/JPEGImageDecoder.h

Issue 1719533002: Modify YUV codecs to match Skia's API change (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Response to Patch Set 3 Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/platform/graphics/ImageFrameGenerator.cpp ('K') | « third_party/WebKit/Source/platform/image-decoders/ImageDecoder.cpp ('k') | third_party/WebKit/Source/platform/image-decoders/jpeg/JPEGImageDecoder.cpp » ('j') | third_party/WebKit/Source/platform/image-decoders/jpeg/JPEGImageDecoder.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/platform/image-decoders/jpeg/JPEGImageDecoder.h

diff --git a/third_party/WebKit/Source/platform/image-decoders/jpeg/JPEGImageDecoder.h b/third_party/WebKit/Source/platform/image-decoders/jpeg/JPEGImageDecoder.h

index 25aa80a4cef47478498a413ed3265849a0a2e72d..0f0cbee9de71d2830aa1dcd5da6d9de52956beef 100644

--- a/third_party/WebKit/Source/platform/image-decoders/jpeg/JPEGImageDecoder.h

+++ b/third_party/WebKit/Source/platform/image-decoders/jpeg/JPEGImageDecoder.h

@@ -43,7 +43,8 @@ public:

void onSetData(SharedBuffer* data) override;

bool hasColorProfile() const override { return m_hasColorProfile; }

IntSize decodedSize() const override { return m_decodedSize; }

- IntSize decodedYUVSize(int component, SizeType) const override;

+ IntSize decodedYUVSize(int component) const override;

+ size_t decodedYUVWidthBytes(int component) const override;

bool setSize(unsigned width, unsigned height) override;

Noel Gordon 2016/03/03 01:25:28 Nit: move this setSize() declaration line; put it

msarett 2016/03/04 19:49:08 Done.

bool canDecodeToYUV() override;

bool decodeToYUV() override;