third_party/WebKit/Source/platform/image-decoders/jpeg/JPEGImageDecoder.h - Issue 1719533002: Modify YUV codecs to match Skia's API change

Side by Side Diff: third_party/WebKit/Source/platform/image-decoders/jpeg/JPEGImageDecoder.h

Issue 1719533002: Modify YUV codecs to match Skia's API change (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Response to Patch Set 3 Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« third_party/WebKit/Source/platform/graphics/ImageFrameGenerator.cpp ('K') | « third_party/WebKit/Source/platform/image-decoders/ImageDecoder.cpp ('k') | third_party/WebKit/Source/platform/image-decoders/jpeg/JPEGImageDecoder.cpp » ('j') | third_party/WebKit/Source/platform/image-decoders/jpeg/JPEGImageDecoder.cpp » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 /*	1 /*

2 * Copyright (C) 2006 Apple Computer, Inc. All rights reserved.	2 * Copyright (C) 2006 Apple Computer, Inc. All rights reserved.

3 *	3 *

4 * Redistribution and use in source and binary forms, with or without	4 * Redistribution and use in source and binary forms, with or without

5 * modification, are permitted provided that the following conditions	5 * modification, are permitted provided that the following conditions

6 * are met:	6 * are met:

7 * 1. Redistributions of source code must retain the above copyright	7 * 1. Redistributions of source code must retain the above copyright

8 * notice, this list of conditions and the following disclaimer.	8 * notice, this list of conditions and the following disclaimer.

9 * 2. Redistributions in binary form must reproduce the above copyright	9 * 2. Redistributions in binary form must reproduce the above copyright

10 * notice, this list of conditions and the following disclaimer in the	10 * notice, this list of conditions and the following disclaimer in the

(...skipping 25 matching lines...) Expand all Loading...
36 WTF_MAKE_NONCOPYABLE(JPEGImageDecoder);	36 WTF_MAKE_NONCOPYABLE(JPEGImageDecoder);

37 public:	37 public:

38 JPEGImageDecoder(AlphaOption, GammaAndColorProfileOption, size_t maxDecodedB ytes);	38 JPEGImageDecoder(AlphaOption, GammaAndColorProfileOption, size_t maxDecodedB ytes);

39 ~JPEGImageDecoder() override;	39 ~JPEGImageDecoder() override;

40	40

41 // ImageDecoder:	41 // ImageDecoder:

42 String filenameExtension() const override { return "jpg"; }	42 String filenameExtension() const override { return "jpg"; }

43 void onSetData(SharedBuffer* data) override;	43 void onSetData(SharedBuffer* data) override;

44 bool hasColorProfile() const override { return m_hasColorProfile; }	44 bool hasColorProfile() const override { return m_hasColorProfile; }

45 IntSize decodedSize() const override { return m_decodedSize; }	45 IntSize decodedSize() const override { return m_decodedSize; }

46 IntSize decodedYUVSize(int component, SizeType) const override;	46 IntSize decodedYUVSize(int component) const override;

	47 size_t decodedYUVWidthBytes(int component) const override;

47 bool setSize(unsigned width, unsigned height) override;	48 bool setSize(unsigned width, unsigned height) override;
Noel Gordon 2016/03/03 01:25:28 Nit: move this setSize() declaration line; put it Nit: move this setSize() declaration line; put it just after the decodedSize() declaration (so all the YUV-related decls are grouped together). msarett 2016/03/04 19:49:08 Done. Show quoted text On 2016/03/03 01:25:28, noel gordon wrote: > Nit: move this setSize() declaration line; put it just after the decodedSize() > declaration (so all the YUV-related decls are grouped together). Done.
48 bool canDecodeToYUV() override;	49 bool canDecodeToYUV() override;

49 bool decodeToYUV() override;	50 bool decodeToYUV() override;

50 void setImagePlanes(PassOwnPtr<ImagePlanes>) override;	51 void setImagePlanes(PassOwnPtr<ImagePlanes>) override;

51 bool hasImagePlanes() const { return m_imagePlanes; }	52 bool hasImagePlanes() const { return m_imagePlanes; }

52	53

53 bool outputScanlines();	54 bool outputScanlines();

54 unsigned desiredScaleNumerator() const;	55 unsigned desiredScaleNumerator() const;

55 void complete();	56 void complete();

56	57

57 void setOrientation(ImageOrientation orientation) { m_orientation = orientat ion; }	58 void setOrientation(ImageOrientation orientation) { m_orientation = orientat ion; }

(...skipping 12 matching lines...) Expand all Loading...
70	71

71 OwnPtr<JPEGImageReader> m_reader;	72 OwnPtr<JPEGImageReader> m_reader;

72 OwnPtr<ImagePlanes> m_imagePlanes;	73 OwnPtr<ImagePlanes> m_imagePlanes;

73 IntSize m_decodedSize;	74 IntSize m_decodedSize;

74 bool m_hasColorProfile;	75 bool m_hasColorProfile;

75 };	76 };

76	77

77 } // namespace blink	78 } // namespace blink

78	79

79 #endif	80 #endif

OLD	NEW