Get rid of inefficient uses of childNodeCount()

Source/core/html/track/vtt/VTTRegion.cpp

Index: Source/core/html/track/vtt/VTTRegion.cpp
diff --git a/Source/core/html/track/vtt/VTTRegion.cpp b/Source/core/html/track/vtt/VTTRegion.cpp
index dd7613ecad3d3ac1e5287e3db4aca9773aa86508..07adcabd4d3a838651bc24325679e6ce7eff2f54 100644
--- a/Source/core/html/track/vtt/VTTRegion.cpp
+++ b/Source/core/html/track/vtt/VTTRegion.cpp
@@ -375,9 +375,9 @@ void VTTRegion::displayLastVTTCueBox()
     float regionBottom = m_regionDisplayTree->getBoundingClientRect()->bottom();
 
     // Find first cue that is not entirely displayed and scroll it upwards.
-    for (size_t i = 0; i < m_cueContainer->childNodeCount() && !m_scrollTimer.isActive(); ++i) {

[Inactive, 2014/02/19 04:13:33]

This one was pretty inefficient :)

[eseidel, 2014/02/19 05:39:54]

We should consider renaming this method "computeChildCount()" or
"countChilden()" to indicate that it does work.

[Inactive, 2014/02/19 14:28:15]

Good idea. Do you mind if I do this in a follow-up patch? There are still quite
a few uses of childNodeCount() so I think it is worth splitting the changes.

-        float childTop = toHTMLDivElement(m_cueContainer->childNode(i))->getBoundingClientRect()->top();
-        float childBottom = toHTMLDivElement(m_cueContainer->childNode(i))->getBoundingClientRect()->bottom();
+    for (Element* child = ElementTraversal::firstWithin(*m_cueContainer); child && !m_scrollTimer.isActive(); child = ElementTraversal::nextSibling(*child)) {
+        float childTop = toHTMLDivElement(child)->getBoundingClientRect()->top();
+        float childBottom = toHTMLDivElement(child)->getBoundingClientRect()->bottom();
 
         if (regionBottom >= childBottom)
             continue;