Get rid of inefficient uses of childNodeCount()

Source/core/html/track/vtt/VTTRegion.cpp

 /*
  * Copyright (C) 2013 Google Inc.  All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 357 matching lines @@
     if (m_scrollTimer.isActive())
         return;
 
     // If it's a scrolling region, add the scrolling class.
     if (isScrollingRegion())
         m_cueContainer->classList()->add(textTrackCueContainerScrollingClass(), ASSERT_NO_EXCEPTION);
 
     float regionBottom = m_regionDisplayTree->getBoundingClientRect()->bottom();
 
     // Find first cue that is not entirely displayed and scroll it upwards.
-    for (size_t i = 0; i < m_cueContainer->childNodeCount() && !m_scrollTimer.isActive(); ++i) {

[Inactive, 2014/02/19 04:13:33]

This one was pretty inefficient :)

[eseidel, 2014/02/19 05:39:54]

We should consider renaming this method "computeChildCount()" or
"countChilden()" to indicate that it does work.

[Inactive, 2014/02/19 14:28:15]

Good idea. Do you mind if I do this in a follow-up patch? There are still quite
a few uses of childNodeCount() so I think it is worth splitting the changes.

-        float childTop = toHTMLDivElement(m_cueContainer->childNode(i))->getBoundingClientRect()->top();
-        float childBottom = toHTMLDivElement(m_cueContainer->childNode(i))->getBoundingClientRect()->bottom();
+    for (Element* child = ElementTraversal::firstWithin(*m_cueContainer); child && !m_scrollTimer.isActive(); child = ElementTraversal::nextSibling(*child)) {
+        float childTop = toHTMLDivElement(child)->getBoundingClientRect()->top();
+        float childBottom = toHTMLDivElement(child)->getBoundingClientRect()->bottom();
 
         if (regionBottom >= childBottom)
             continue;
 
         float height = childBottom - childTop;
 
         m_currentTop -= std::min(height, childBottom - regionBottom);
         m_cueContainer->setInlineStyleProperty(CSSPropertyTop, m_currentTop, CSSPrimitiveValue::CSS_PX);
 
         startTimer();
@@ skipping 74 matching lines @@
 
 void VTTRegion::scrollTimerFired(Timer<VTTRegion>*)
 {
     WTF_LOG(Media, "VTTRegion::scrollTimerFired");
 
     stopTimer();
     displayLastVTTCueBox();
 }
 
 } // namespace WebCore