Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(35)

Issue 1719273002: Added WebRTC.Video.H264Encoder/DecoderImpl.Event histograms. (Closed)

Created:
4 years, 10 months ago by hbos_chromium
Modified:
4 years, 9 months ago
Reviewers:
rkaplow, Stefan
CC:
chromium-reviews, asvitkine+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Added WebRTC.Video.H264Encoder/DecoderImpl.Event histograms. These histograms will be used to track how many times this encoder/decoder is initialized/an error occurs. WebRTC sibling CL: https://codereview.webrtc.org/1716173002/ BUG=chromium:500605, chromium:468365 Committed: https://crrev.com/88f1ea245bfd8d10dd4c247c076de41eac3acd06 Cr-Commit-Position: refs/heads/master@{#377541}

Patch Set 1 : #

Patch Set 2 : Event enum instead of counts (to match sibling CL update) #

Unified diffs Side-by-side diffs Delta from patch set Stats (+36 lines, -0 lines) Patch
M tools/metrics/histograms/histograms.xml View 1 2 chunks +36 lines, -0 lines 0 comments Download

Messages

Total messages: 19 (11 generated)
hbos_chromium
Please take a look, rkaplow.
4 years, 10 months ago (2016-02-22 21:04:03 UTC) #3
hbos_chromium
+holmer for a second reviewer.
4 years, 10 months ago (2016-02-23 13:00:57 UTC) #6
Stefan
lgtm
4 years, 10 months ago (2016-02-23 13:12:58 UTC) #7
hbos_chromium
The sibling CL that is landing atm was updated to use enum histograms instead of ...
4 years, 9 months ago (2016-02-24 10:41:11 UTC) #10
rkaplow
lgtm
4 years, 9 months ago (2016-02-24 16:10:21 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1719273002/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1719273002/80001
4 years, 9 months ago (2016-02-25 07:42:41 UTC) #15
commit-bot: I haz the power
Committed patchset #2 (id:80001)
4 years, 9 months ago (2016-02-25 09:16:47 UTC) #17
commit-bot: I haz the power
4 years, 9 months ago (2016-02-25 09:17:35 UTC) #19
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/88f1ea245bfd8d10dd4c247c076de41eac3acd06
Cr-Commit-Position: refs/heads/master@{#377541}

Powered by Google App Engine
This is Rietveld 408576698