Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1719273002:
Added WebRTC.Video.H264Encoder/DecoderImpl.Event histograms. (Closed)
|
Created:
4 years, 10 months ago by hbos_chromium Modified:
4 years, 9 months ago CC:
chromium-reviews, asvitkine+watch_chromium.org Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionAdded WebRTC.Video.H264Encoder/DecoderImpl.Event histograms.
These histograms will be used to track how many times
this encoder/decoder is initialized/an error occurs.
WebRTC sibling CL:
https://codereview.webrtc.org/1716173002/
BUG=chromium:500605, chromium:468365
Committed: https://crrev.com/88f1ea245bfd8d10dd4c247c076de41eac3acd06
Cr-Commit-Position: refs/heads/master@{#377541}
Patch Set 1 : #Patch Set 2 : Event enum instead of counts (to match sibling CL update) #Messages
Total messages: 19 (11 generated)
Patchset #1 (id:1) has been deleted
hbos@chromium.org changed reviewers: + rkaplow@chromium.org
Please take a look, rkaplow.
Description was changed from ========== Added WebRTC.Video.H264Encoder/DecoderImpl.* histograms. These histograms will be used to track how many times this encoder/decoder is initialized/an error occurs. Sibling CL: https://codereview.webrtc.org/1716173002/ BUG=chromium:500605, chromium:468365 ========== to ========== Added WebRTC.Video.H264Encoder/DecoderImpl.* histograms. These histograms will be used to track how many times this encoder/decoder is initialized/an error occurs. WebRTC sibling CL: https://codereview.webrtc.org/1716173002/ BUG=chromium:500605, chromium:468365 ==========
hbos@chromium.org changed reviewers: + holmer@chromium.org
+holmer for a second reviewer.
lgtm
Patchset #3 (id:60001) has been deleted
Patchset #2 (id:40001) has been deleted
The sibling CL that is landing atm was updated to use enum histograms instead of counts (counting enum values Init and Error) so I updated this CL.
Description was changed from ========== Added WebRTC.Video.H264Encoder/DecoderImpl.* histograms. These histograms will be used to track how many times this encoder/decoder is initialized/an error occurs. WebRTC sibling CL: https://codereview.webrtc.org/1716173002/ BUG=chromium:500605, chromium:468365 ========== to ========== Added WebRTC.Video.H264Encoder/DecoderImpl.Event histograms. These histograms will be used to track how many times this encoder/decoder is initialized/an error occurs. WebRTC sibling CL: https://codereview.webrtc.org/1716173002/ BUG=chromium:500605, chromium:468365 ==========
lgtm
The CQ bit was checked by hbos@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from holmer@chromium.org Link to the patchset: https://codereview.chromium.org/1719273002/#ps80001 (title: "Event enum instead of counts (to match sibling CL update)")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1719273002/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1719273002/80001
Message was sent while issue was closed.
Description was changed from ========== Added WebRTC.Video.H264Encoder/DecoderImpl.Event histograms. These histograms will be used to track how many times this encoder/decoder is initialized/an error occurs. WebRTC sibling CL: https://codereview.webrtc.org/1716173002/ BUG=chromium:500605, chromium:468365 ========== to ========== Added WebRTC.Video.H264Encoder/DecoderImpl.Event histograms. These histograms will be used to track how many times this encoder/decoder is initialized/an error occurs. WebRTC sibling CL: https://codereview.webrtc.org/1716173002/ BUG=chromium:500605, chromium:468365 ==========
Message was sent while issue was closed.
Committed patchset #2 (id:80001)
Message was sent while issue was closed.
Description was changed from ========== Added WebRTC.Video.H264Encoder/DecoderImpl.Event histograms. These histograms will be used to track how many times this encoder/decoder is initialized/an error occurs. WebRTC sibling CL: https://codereview.webrtc.org/1716173002/ BUG=chromium:500605, chromium:468365 ========== to ========== Added WebRTC.Video.H264Encoder/DecoderImpl.Event histograms. These histograms will be used to track how many times this encoder/decoder is initialized/an error occurs. WebRTC sibling CL: https://codereview.webrtc.org/1716173002/ BUG=chromium:500605, chromium:468365 Committed: https://crrev.com/88f1ea245bfd8d10dd4c247c076de41eac3acd06 Cr-Commit-Position: refs/heads/master@{#377541} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/88f1ea245bfd8d10dd4c247c076de41eac3acd06 Cr-Commit-Position: refs/heads/master@{#377541} |
